lukas.pupkalipinski/Aniworld
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor: simplify NFO handling, remove legacy services

Browse Source 
- Drop nfo_factory, nfo_repair_service, nfo_service, series_manager_service
- Delete key_resolution_service, consolidate into folder_rename_service
- Remove bulk of NFO-related tests (coverage via integration tests)
- Streamline SeriesApp, background_loader, initialization services
- Add folder_rename_service to scheduler

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This commit is contained in:
Lukas
2026-06-04 18:54:31 +02:00
parent 97caaf0d18
commit 21af502184
53 changed files with 175 additions and 16588 deletions
Download Patch File Download Diff File Expand all files Collapse all files

49
tests/unit/test_folder_scan_service.py
View File

@@ -140,17 +140,14 @@ class TestRunFolderScanPrerequisites:
# ---------------------------------------------------------------------------
class TestNfoRepairIntegration:
"""Test perform_nfo_repair_scan is called inside run_folder_scan."""
"""Test NFO repair scan behavior - NFO service removed, now stub."""
@pytest.mark.asyncio
async def test_calls_perform_nfo_repair_scan(self, folder_scan_service, tmp_path):
"""run_folder_scan must call perform_nfo_repair_scan."""
async def test_nfo_repair_skipped(self, folder_scan_service, tmp_path):
"""NFO repair scan is skipped since NFO service removed."""
with patch.object(
folder_scan_service, "_prerequisites_met", return_value=True
), patch(
"src.server.services.scheduler.folder_scan_service.perform_nfo_repair_scan",
new_callable=AsyncMock,
) as mock_repair, patch(
"src.server.services.scheduler.folder_rename_service.validate_and_rename_series_folders",
new_callable=AsyncMock,
return_value={"scanned": 0, "renamed": 0, "skipped": 0, "errors": 0},
@@ -161,34 +158,8 @@ class TestNfoRepairIntegration:
return_value={"scanned": 0, "downloaded": 0, "skipped": 0, "errors": 0},
):
await folder_scan_service.run_folder_scan()
mock_repair.assert_awaited_once_with(background_loader=None)
@pytest.mark.asyncio
async def test_nfo_repair_failure_does_not_crash_scan(
self, folder_scan_service, tmp_path
):
"""If perform_nfo_repair_scan raises, the broad except catches it
and the scan stops — remaining steps are NOT invoked."""
with patch.object(
folder_scan_service, "_prerequisites_met", return_value=True
), patch(
"src.server.services.scheduler.folder_scan_service.perform_nfo_repair_scan",
new_callable=AsyncMock,
side_effect=RuntimeError("repair failed"),
) as mock_repair, patch(
"src.server.services.scheduler.folder_rename_service.validate_and_rename_series_folders",
new_callable=AsyncMock,
return_value={"scanned": 0, "renamed": 0, "skipped": 0, "errors": 0},
) as mock_rename, patch.object(
folder_scan_service,
"check_and_download_missing_posters",
new_callable=AsyncMock,
return_value={"scanned": 0, "downloaded": 0, "skipped": 0, "errors": 0},
):
await folder_scan_service.run_folder_scan()
mock_repair.assert_awaited_once()
# Broad except stops the scan; rename/poster are skipped
mock_rename.assert_not_called()
# NFO repair is skipped - verify scan continues to folder rename
# No exception means the stub worked correctly
# ---------------------------------------------------------------------------
@@ -565,13 +536,10 @@ class TestRunFolderScanFull:
@pytest.mark.asyncio
async def test_full_scan_happy_path(self, folder_scan_service, tmp_path):
"""All sub-tasks succeed."""
"""All sub-tasks succeed. NFO repair is now a stub."""
with patch.object(
folder_scan_service, "_prerequisites_met", return_value=True
), patch(
"src.server.services.scheduler.folder_scan_service.perform_nfo_repair_scan",
new_callable=AsyncMock,
) as mock_repair, patch(
"src.server.services.scheduler.folder_rename_service.validate_and_rename_series_folders",
new_callable=AsyncMock,
return_value={"scanned": 3, "renamed": 1, "skipped": 1, "errors": 1},
@@ -583,7 +551,7 @@ class TestRunFolderScanFull:
) as mock_poster:
await folder_scan_service.run_folder_scan()
mock_repair.assert_awaited_once_with(background_loader=None)
# NFO repair is now a stub - not awaited in code
mock_rename.assert_awaited_once()
mock_poster.assert_awaited_once()
@@ -592,9 +560,6 @@ class TestRunFolderScanFull:
"""Empty library → all stats zero."""
with patch.object(
folder_scan_service, "_prerequisites_met", return_value=True
), patch(
"src.server.services.scheduler.folder_scan_service.perform_nfo_repair_scan",
new_callable=AsyncMock,
), patch(
"src.server.services.scheduler.folder_rename_service.validate_and_rename_series_folders",
new_callable=AsyncMock,