From 40d44d8b94f5cc9f36f899652d391947a9daecd4 Mon Sep 17 00:00:00 2001 From: Lukas Date: Sun, 28 Jun 2026 18:45:33 +0200 Subject: [PATCH] docs(tasks): remove completed Task 22 setup flow test issue Make master_password_hash optional in development config None default allows env var to override. Hardcoded dev hash removed. --- Docs/tasks.md | 16 ---------------- src/server/config/development.py | 7 +++---- 2 files changed, 3 insertions(+), 20 deletions(-) diff --git a/Docs/tasks.md b/Docs/tasks.md index a3b65b0..9d1ff92 100644 --- a/Docs/tasks.md +++ b/Docs/tasks.md @@ -1,19 +1,3 @@ -## Task 22: UI Setup Flow - Setup Page Loads - -**Suite:** `Robot.Ui.Setup Flow` -**Test:** `Setup Page Loads` -**Result:** FAIL -**Error:** `TimeoutError: locator.waitFor: Timeout 5000ms exceeded. waiting for locator('id=setup-form') to be visible` - -**Instructions:** -- The setup flow tests expect `#setup-form` to be visible, but it is not found. -- Investigate the setup page frontend code. -- The app may already be configured, causing the setup page to redirect to the dashboard instead of showing the form. -- Check if a suite-level setup/teardown resets the app to an unconfigured state before running setup flow tests. -- Update the test setup in `tests/robot/ui/setup_flow.robot` or the backend to ensure the setup form is available. - ---- - ## Task 23: UI Setup Flow - Password Strength Weak **Suite:** `Robot.Ui.Setup Flow` diff --git a/src/server/config/development.py b/src/server/config/development.py index b3a8a9c..569b810 100644 --- a/src/server/config/development.py +++ b/src/server/config/development.py @@ -38,12 +38,11 @@ class DevelopmentSettings(BaseSettings): ) """Password salt (non-production value for development).""" - master_password_hash: str = Field( - default="$2b$12$wP0KBVbJKVAb8CdSSXw0NeGTKCk" - "bw4fSAFXIqR2/wDqPSEBn9w7lS", + master_password_hash: Optional[str] = Field( + default=None, env="MASTER_PASSWORD_HASH" ) - """Hash of the master password (dev: 'password').""" + """Hash of the master password. None means not configured (env var overrides).""" master_password: str = Field(default="password", env="MASTER_PASSWORD") """Master password for development (NEVER use in production)."""