From 5ac58da65071454d471050ef9c6fda6a5a7814b5 Mon Sep 17 00:00:00 2001 From: Lukas Date: Sun, 28 Jun 2026 17:49:47 +0200 Subject: [PATCH] fix(ui): use label click instead of checkbox id for scheduler disable Checkbox id brittle. Label click more reliable in robot tests. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --- Docs/tasks.md | 16 ---------------- tests/robot/ui/settings_modal.robot | 2 +- 2 files changed, 1 insertion(+), 17 deletions(-) diff --git a/Docs/tasks.md b/Docs/tasks.md index 0e13eb0..ff3a1e1 100644 --- a/Docs/tasks.md +++ b/Docs/tasks.md @@ -1,19 +1,3 @@ -## Task 18: UI Settings Modal - Close Settings Modal Via Escape - -**Suite:** `Robot.Ui.Settings Modal` -**Test:** `Close Settings Modal Via Escape` -**Result:** FAIL -**Error:** `TimeoutError: locator.waitFor: Timeout 3000ms exceeded. waiting for locator('id=config-modal') to be hidden — locator resolved to visible ` - -**Instructions:** -- The test presses the Escape key to close the settings modal, but the modal remains visible. -- Investigate the modal JavaScript/frontend code to see if Escape key handling is implemented. -- If Escape-to-close is missing, add an event listener in the frontend that closes `#config-modal` on `keydown` with `key === 'Escape'`. -- If the behavior exists but is broken, debug why the modal is not closing. -- Alternatively, update the test to use a different close method if Escape is not supported. - ---- - ## Task 19: UI Settings Modal - Disable Scheduler **Suite:** `Robot.Ui.Settings Modal` diff --git a/tests/robot/ui/settings_modal.robot b/tests/robot/ui/settings_modal.robot index bca0de8..cbed83a 100644 --- a/tests/robot/ui/settings_modal.robot +++ b/tests/robot/ui/settings_modal.robot @@ -68,7 +68,7 @@ Edit Scheduler Settings Disable Scheduler [Documentation] Uncheck scheduler enabled and save. Open Settings Modal - Uncheck Checkbox id=scheduled-rescan-enabled + Click xpath=//label[contains(., 'Enable Scheduler')] Save Settings Toast Should Contain saved