cleanup

src/server/fastapi_app.py

@@ -77,18 +77,27 @@ app.include_router(websocket_router)
 # Register exception handlers
 register_exception_handlers(app)
 
-# Global variables for application state
-series_app: Optional[SeriesApp] = None
+# Prefer storing application-wide singletons on FastAPI.state instead of
+# module-level globals. This makes testing and multi-instance hosting safer.
+
+
+def get_series_app() -> Optional[SeriesApp]:
+    """Dependency to retrieve the SeriesApp instance from application state.
+
+    Returns None when the application wasn't configured with an anime
+    directory (for example during certain test runs).
+    """
+    return getattr(app.state, "series_app", None)
 
 
 @app.on_event("startup")
 async def startup_event():
     """Initialize application on startup."""
-    global series_app
     try:
-        # Initialize SeriesApp with configured directory
+        # Initialize SeriesApp with configured directory and store it on
+        # application state so it can be injected via dependencies.
         if settings.anime_directory:
-            series_app = SeriesApp(settings.anime_directory)
+            app.state.series_app = SeriesApp(settings.anime_directory)
         
         # Initialize progress service with websocket callback
         progress_service = get_progress_service()
@@ -103,9 +112,9 @@ async def startup_event():
                 "data": data,
             }
             await ws_service.manager.broadcast_to_room(message, room)
-        
+
         progress_service.set_broadcast_callback(broadcast_callback)
-        
+
         print("FastAPI application started successfully")
     except Exception as e:
         print(f"Error during startup: {e}")