fix(nfo): pass anime_service to _create_or_update_nfo in anime endpoints
POST /api/anime/{key}/regenerate-nfo and PUT /api/anime/{key}/settings
(both of which can regenerate NFO when apply_to_nfo=True) were calling
_create_or_update_nfo without the required anime_service argument,
producing HTTP 500 with 'missing 1 required positional argument:
anime_service' on the anime-settings page.
Also drops the unused series_data parameter from
_create_or_update_nfo's signature — the value was constructed at every
call site but never read inside the function body. All four callers
in anime.py and nfo.py are updated to match.
This commit is contained in:
@@ -1650,17 +1650,11 @@ async def update_anime_settings(
|
|||||||
# Lazy-import to avoid heavy deps when not used
|
# Lazy-import to avoid heavy deps when not used
|
||||||
from src.server.api.nfo import _create_or_update_nfo
|
from src.server.api.nfo import _create_or_update_nfo
|
||||||
|
|
||||||
series_data = {
|
|
||||||
"key": anime_key,
|
|
||||||
"name": db_series.name,
|
|
||||||
"folder": db_series.folder,
|
|
||||||
"tmdb_id": db_series.tmdb_id,
|
|
||||||
}
|
|
||||||
await _create_or_update_nfo(
|
await _create_or_update_nfo(
|
||||||
key=anime_key,
|
key=anime_key,
|
||||||
folder=db_series.folder,
|
folder=db_series.folder,
|
||||||
tmdb_id=db_series.tmdb_id,
|
tmdb_id=db_series.tmdb_id,
|
||||||
series_data=series_data,
|
anime_service=anime_service,
|
||||||
)
|
)
|
||||||
except HTTPException:
|
except HTTPException:
|
||||||
raise
|
raise
|
||||||
@@ -1727,17 +1721,11 @@ async def regenerate_anime_nfo(
|
|||||||
try:
|
try:
|
||||||
from src.server.api.nfo import _create_or_update_nfo
|
from src.server.api.nfo import _create_or_update_nfo
|
||||||
|
|
||||||
series_data = {
|
|
||||||
"key": anime_key,
|
|
||||||
"name": db_series.name,
|
|
||||||
"folder": db_series.folder,
|
|
||||||
"tmdb_id": tmdb_id,
|
|
||||||
}
|
|
||||||
repaired_tags = await _create_or_update_nfo(
|
repaired_tags = await _create_or_update_nfo(
|
||||||
key=anime_key,
|
key=anime_key,
|
||||||
folder=db_series.folder,
|
folder=db_series.folder,
|
||||||
tmdb_id=tmdb_id,
|
tmdb_id=tmdb_id,
|
||||||
series_data=series_data,
|
anime_service=anime_service,
|
||||||
)
|
)
|
||||||
except HTTPException:
|
except HTTPException:
|
||||||
raise
|
raise
|
||||||
|
|||||||
@@ -243,7 +243,6 @@ async def repair_nfo_settings(
|
|||||||
key=key,
|
key=key,
|
||||||
folder=folder,
|
folder=folder,
|
||||||
tmdb_id=tmdb_id,
|
tmdb_id=tmdb_id,
|
||||||
series_data=series_data,
|
|
||||||
anime_service=anime_service,
|
anime_service=anime_service,
|
||||||
)
|
)
|
||||||
except Exception as exc:
|
except Exception as exc:
|
||||||
@@ -287,7 +286,6 @@ async def _create_or_update_nfo(
|
|||||||
key: str,
|
key: str,
|
||||||
folder: str,
|
folder: str,
|
||||||
tmdb_id: int,
|
tmdb_id: int,
|
||||||
series_data: dict,
|
|
||||||
anime_service: AnimeService,
|
anime_service: AnimeService,
|
||||||
) -> List[str]:
|
) -> List[str]:
|
||||||
"""Create or update NFO file for a series.
|
"""Create or update NFO file for a series.
|
||||||
@@ -592,7 +590,6 @@ async def batch_repair_nfo(
|
|||||||
key=key,
|
key=key,
|
||||||
folder=folder,
|
folder=folder,
|
||||||
tmdb_id=tmdb_id,
|
tmdb_id=tmdb_id,
|
||||||
series_data=series_data,
|
|
||||||
anime_service=anime_service,
|
anime_service=anime_service,
|
||||||
)
|
)
|
||||||
results["success"] += 1
|
results["success"] += 1
|
||||||
|
|||||||
Reference in New Issue
Block a user