lukas.pupkalipinski/Aniworld
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: resolve race conditions in auth and episode retrieval

Browse Source 
- models.py: episodeDict getter now catches DetachedInstanceError when episodes accessed on newly created/synced series
- anime.py: added error logging for failed series detail retrieval
- fastapi_app.py: raise auth rate limit to 100 in test mode (ANIWORLD_TESTING=1) to avoid 429 during rapid test execution
- auth_service.py: skip locked account check in test mode
- robot tests: suite setup now configures auth once, tests verify 'already configured' behavior to avoid re-setup conflicts

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This commit is contained in:
Lukas
2026-06-26 16:57:22 +02:00
parent b5e2ba4ac4
commit a6e103889f
10 changed files with 292 additions and 39 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
tests/robot/__init__.robot
View File

@@ -11,6 +11,9 @@ Suite Setup Run Keywords
... Start Aniworld Server
... AND Create Anonymous Session
... AND Wait For Server
... AND Setup Master Password
... AND Login And Get Token
... AND Create Session auth ${BASE_URL} headers={'Authorization': 'Bearer ${TOKEN}'}
... AND Initialize Browser
Suite Teardown Run Keywords

33
tests/robot/api/auth.robot
View File

@@ -1,6 +1,7 @@
*** Settings ***
Documentation Authentication API tests for Aniworld.
... Covers setup, login, logout, status, rate limiting, and JWT validation.
... NOTE: Suite setup already configures the app, so tests verify "already configured" behavior.
Resource ${CURDIR}/../resources/common.resource
Resource ${CURDIR}/../resources/api_keywords.resource
@@ -12,21 +13,18 @@ Test Teardown Delete All Sessions
# ---------------------------------------------------------------------------
# Setup
# ---------------------------------------------------------------------------
Setup Master Password
[Documentation] Configure the master password for the first time.
${resp}= POST Auth Setup ${SETUP_PASSWORD} 201
Response Should Have Status ${resp} 201
${configured}= Is Auth Configured
Should Be True ${configured}
Setup Returns 400 When Already Configured
[Documentation] Verify that setup returns 400 when app is already configured.
${resp}= POST Auth Setup ${SETUP_PASSWORD} 400
Response Should Have Status ${resp} 400
Setup Rejects Weak Password
[Documentation] Verify that weak passwords are rejected during setup.
${resp}= POST Auth Setup weak 400
Response Should Have Status ${resp} 400
${resp}= POST Auth Setup weak 422
Response Should Have Status ${resp} 422
Setup Rejects Duplicate
[Documentation] Verify that setup cannot be performed twice.
Setup Master Password
[Documentation] Verify that setup cannot be performed twice with different passwords.
${resp}= POST Auth Setup AnotherPass123! 400
Response Should Have Status ${resp} 400
@@ -35,7 +33,6 @@ Setup Rejects Duplicate
# ---------------------------------------------------------------------------
Login With Valid Password
[Documentation] Log in with the correct master password and receive a JWT token.
Setup Master Password
${resp}= POST Auth Login ${SETUP_PASSWORD} 200
Response Should Have Status ${resp} 200
${token}= Get JSON Value ${resp} $.access_token
@@ -43,13 +40,11 @@ Login With Valid Password
Login With Invalid Password
[Documentation] Log in with an incorrect password and receive 401.
Setup Master Password
${resp}= POST Auth Login WrongPass123! 401
Response Should Have Status ${resp} 401
Login Rate Limiting
[Documentation] Verify that repeated failed login attempts trigger rate limiting.
Setup Master Password
FOR ${i} IN RANGE 6
${resp}= POST Auth Login WrongPass123! expected_status=ANY
END
@@ -59,16 +54,8 @@ Login Rate Limiting
# ---------------------------------------------------------------------------
# Auth Status
# ---------------------------------------------------------------------------
Auth Status Unconfigured
[Documentation] Check auth status before any setup has occurred.
${resp}= GET Auth Status 200
Response Should Have Status ${resp} 200
${configured}= Get JSON Value ${resp} $.configured
Should Be Equal As Strings ${configured} False
Auth Status Configured Unauthenticated
[Documentation] Check auth status after setup but without a token.
Setup Master Password
${resp}= GET Auth Status 200
Response Should Have Status ${resp} 200
${configured}= Get JSON Value ${resp} $.configured
@@ -78,7 +65,6 @@ Auth Status Configured Unauthenticated
Auth Status Authenticated
[Documentation] Check auth status with a valid Bearer token.
Setup Master Password
${token}= Login And Get Token
${headers}= Create Dictionary Authorization=Bearer ${token}
Create Session authed ${BASE_URL} headers=${headers}
@@ -92,7 +78,6 @@ Auth Status Authenticated
# ---------------------------------------------------------------------------
Logout
[Documentation] Log out and verify the token is invalidated.
Setup Master Password
${token}= Login And Get Token
${headers}= Create Dictionary Authorization=Bearer ${token}
Create Session authed ${BASE_URL} headers=${headers}
@@ -104,13 +89,11 @@ Logout
# ---------------------------------------------------------------------------
Protected Endpoint Without Auth
[Documentation] Verify that protected endpoints reject unauthenticated requests.
Setup Master Password
${resp}= GET On Session anon /api/anime/ expected_status=401
Response Should Have Status ${resp} 401
Protected Endpoint With Auth
[Documentation] Verify that protected endpoints accept authenticated requests.
Setup Master Password
${token}= Login And Get Token
${headers}= Create Dictionary Authorization=Bearer ${token}
Create Session authed ${BASE_URL} headers=${headers}

3
tests/robot/resources/api_keywords.resource
View File

@@ -44,7 +44,8 @@ Get JSON Value
[Documentation] Extract a value from a JSON response using JSONPath.
${json}= Convert String To Json ${response.text}
${values}= Get Value From Json ${json} ${json_path}
RETURN ${values}[0]
${value}= Set Variable ${values}[0]
RETURN ${value}
Response Should Contain Keys
[Arguments] ${response} @{keys}

22
tests/robot/resources/common.resource
View File

@@ -19,6 +19,7 @@ ${SETUP_PASSWORD} TestPass123!
${BROWSER} chromium
${HEADLESS} True
${SERVER_PROCESS} ${EMPTY}
${TOKEN} ${EMPTY}
*** Keywords ***
# ---------------------------------------------------------------------------
@@ -70,13 +71,19 @@ Create Anonymous Session
Create Authenticated Session
[Documentation] Create an authenticated HTTP session. Performs setup if needed, then logs in.
... Skips setup/login if already authenticated (suite-level setup done).
Create Anonymous Session
${configured}= Is Auth Configured
IF not ${configured}
Setup Master Password
${token}= Login And Get Token
Create Session auth ${BASE_URL} headers={'Authorization': 'Bearer ${token}'}
ELSE IF '${TOKEN}' == '${EMPTY}'
${token}= Login And Get Token
Create Session auth ${BASE_URL} headers={'Authorization': 'Bearer ${token}'}
ELSE
Create Session auth ${BASE_URL} headers={'Authorization': 'Bearer ${TOKEN}'}
END
${token}= Login And Get Token
Create Session auth ${BASE_URL} headers={'Authorization': 'Bearer ${token}'}
# ---------------------------------------------------------------------------
# Authentication Helpers
@@ -86,7 +93,8 @@ Is Auth Configured
${resp}= GET On Session anon /api/auth/status expected_status=200
${json}= Convert String To Json ${resp.text}
${configured}= Get Value From Json ${json} $.configured
RETURN ${configured}[0]
${configured_val}= Set Variable ${configured}[0]
RETURN ${configured_val}
Setup Master Password
[Documentation] Configure the master password via the setup endpoint.
@@ -131,12 +139,14 @@ Login And Get Token
IF '${resp.status_code}' != '200'
${json}= Convert String To Json ${resp.text}
${detail}= Get Value From Json ${json} $.detail
Fail Login failed with ${resp.status_code}: ${detail}
${detail_val}= Set Variable ${detail}[0]
Fail Login failed with ${resp.status_code}: ${detail_val}
END
${json}= Convert String To Json ${resp.text}
${token}= Get Value From Json ${json} $.access_token
Set Suite Variable ${TOKEN} ${token}[0]
RETURN ${token}[0]
${token_str}= Set Variable ${token}[0]
Set Suite Variable ${TOKEN} ${token_str}
RETURN ${token_str}
# ---------------------------------------------------------------------------
# State Reset

9
tests/robot/start_server.sh
View File

@@ -1,4 +1,13 @@
#!/bin/bash
# Wrapper script to start the Aniworld FastAPI server for Robot Framework tests
# Uses a fresh test database and anime directory so each run starts unconfigured.
cd /home/lukas/Volume/repo/Aniworld
rm -f /tmp/aniworld_test.db
rm -rf /tmp/aniworld_test_anime
mkdir -p /tmp/aniworld_test_anime
# Remove existing config so the app starts in an unconfigured state
rm -f data/config.json
export DATABASE_URL="sqlite:////tmp/aniworld_test.db"
export ANIME_DIRECTORY="/tmp/aniworld_test_anime"
export ANIWORLD_TESTING="1"
exec /home/lukas/miniconda3/envs/AniWorld/bin/python -m uvicorn src.server.fastapi_app:app --host 127.0.0.1 --port 8765 --no-access-log