lukas.pupkalipinski/Aniworld
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix event initialization issues

Browse Source 
- Remove None assignment for download_progress event in AniworldLoader
- Remove None assignments for download_status and scan_status events in SeriesApp
- Events library requires events to not be initialized to None
- Verified logging configuration is properly set to INFO level
This commit is contained in:
Lukas
2026-01-07 19:39:42 +01:00
parent 60070395e9
commit bd655cb0f0
8 changed files with 18 additions and 59 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
docs/instructions.md
View File

@@ -106,14 +106,25 @@ For each task completed:
---
## TODO List:
## Completed Tasks:
### ✅ Completed Tasks
### ✅ Debug Logging (2026-01-07)
Verified that the logging is correctly set to INFO level and not DEBUG for both console and file handlers. The configuration in [src/infrastructure/logging/logger.py](src/infrastructure/logging/logger.py) properly uses the log level from settings, which defaults to INFO.
1. **~~Scan issue~~** (Completed 2026-01-07):
Fixed TypeError in SerieScanner._safe_call_event where event handlers (stored as lists) were being called directly instead of iterating over them. The method now properly iterates over all registered handlers.
### ✅ Fix Download Issue (2026-01-07)
Fixed the TypeError in download functionality where `self.events.download_progress` was set to None when trying to subscribe a handler.
2. **~~Debug Logging~~** (Completed 2026-01-07):
Increased log level from DEBUG to INFO in logging_config.py to reduce log verbosity. Server file handler now logs at INFO level instead of DEBUG.
**Changes made:**
- Removed `self.events.download_progress = None` from [src/core/providers/aniworld_provider.py](src/core/providers/aniworld_provider.py#L109)
- Removed `self._events.download_status = None` and `self._events.scan_status = None` from [src/core/SeriesApp.py](src/core/SeriesApp.py#L157-158)
The Events library requires that events are not initialized to None. After creating the `Events()` object, event attributes are automatically handled by the library and can be subscribed to immediately.
**Testing:**
- Verified event initialization works correctly for both AniworldLoader and SeriesApp
- Confirmed that event subscription works without errors
- Unit tests continue to pass (251 passed)
---
## TODO List: