Fix event initialization issues
- Remove None assignment for download_progress event in AniworldLoader - Remove None assignments for download_status and scan_status events in SeriesApp - Events library requires events to not be initialized to None - Verified logging configuration is properly set to INFO level
This commit is contained in:
parent
60070395e9
commit
bd655cb0f0
Binary file not shown.
@ -17,7 +17,7 @@
|
|||||||
"keep_days": 30
|
"keep_days": 30
|
||||||
},
|
},
|
||||||
"other": {
|
"other": {
|
||||||
"master_password_hash": "$pbkdf2-sha256$29000$kxLi/J9zTukdA6BUitHa.w$tLseUX7kHXkjl3N9pFAd2Y.dzveyx0buInX7Wu9MHLg",
|
"master_password_hash": "$pbkdf2-sha256$29000$HoPQujcmhFCqdY6RkvI.Rw$YphPCe3vAewoVMlzHgaoX7uarFx0GVSQaplb0KYvIFI",
|
||||||
"anime_directory": "/mnt/server/serien/Serien/"
|
"anime_directory": "/mnt/server/serien/Serien/"
|
||||||
},
|
},
|
||||||
"version": "1.0.0"
|
"version": "1.0.0"
|
||||||
|
|||||||
@ -1,24 +0,0 @@
|
|||||||
{
|
|
||||||
"name": "Aniworld",
|
|
||||||
"data_dir": "data",
|
|
||||||
"scheduler": {
|
|
||||||
"enabled": true,
|
|
||||||
"interval_minutes": 60
|
|
||||||
},
|
|
||||||
"logging": {
|
|
||||||
"level": "INFO",
|
|
||||||
"file": null,
|
|
||||||
"max_bytes": null,
|
|
||||||
"backup_count": 3
|
|
||||||
},
|
|
||||||
"backup": {
|
|
||||||
"enabled": false,
|
|
||||||
"path": "data/backups",
|
|
||||||
"keep_days": 30
|
|
||||||
},
|
|
||||||
"other": {
|
|
||||||
"master_password_hash": "$pbkdf2-sha256$29000$X4uRMibE.N.bM.acs1ZKSQ$88em69lhlaLiS6vcF9oqf4pCC8KBbIj/O3h4cQFwM.I",
|
|
||||||
"anime_directory": "/mnt/server/serien/Serien/"
|
|
||||||
},
|
|
||||||
"version": "1.0.0"
|
|
||||||
}
|
|
||||||
@ -1,24 +0,0 @@
|
|||||||
{
|
|
||||||
"name": "Aniworld",
|
|
||||||
"data_dir": "data",
|
|
||||||
"scheduler": {
|
|
||||||
"enabled": true,
|
|
||||||
"interval_minutes": 60
|
|
||||||
},
|
|
||||||
"logging": {
|
|
||||||
"level": "INFO",
|
|
||||||
"file": null,
|
|
||||||
"max_bytes": null,
|
|
||||||
"backup_count": 3
|
|
||||||
},
|
|
||||||
"backup": {
|
|
||||||
"enabled": false,
|
|
||||||
"path": "data/backups",
|
|
||||||
"keep_days": 30
|
|
||||||
},
|
|
||||||
"other": {
|
|
||||||
"master_password_hash": "$pbkdf2-sha256$29000$TQlBSOndm1MKAWAMoTRGKA$a/q5miowGpjWSc71WDvqBpL9JJmuAO1FrZlCi3qwp2E",
|
|
||||||
"anime_directory": "/mnt/server/serien/Serien/"
|
|
||||||
},
|
|
||||||
"version": "1.0.0"
|
|
||||||
}
|
|
||||||
@ -106,14 +106,25 @@ For each task completed:
|
|||||||
|
|
||||||
---
|
---
|
||||||
|
|
||||||
## TODO List:
|
## Completed Tasks:
|
||||||
|
|
||||||
### ✅ Completed Tasks
|
### ✅ Debug Logging (2026-01-07)
|
||||||
|
Verified that the logging is correctly set to INFO level and not DEBUG for both console and file handlers. The configuration in [src/infrastructure/logging/logger.py](src/infrastructure/logging/logger.py) properly uses the log level from settings, which defaults to INFO.
|
||||||
|
|
||||||
1. **~~Scan issue~~** (Completed 2026-01-07):
|
### ✅ Fix Download Issue (2026-01-07)
|
||||||
Fixed TypeError in SerieScanner._safe_call_event where event handlers (stored as lists) were being called directly instead of iterating over them. The method now properly iterates over all registered handlers.
|
Fixed the TypeError in download functionality where `self.events.download_progress` was set to None when trying to subscribe a handler.
|
||||||
|
|
||||||
2. **~~Debug Logging~~** (Completed 2026-01-07):
|
**Changes made:**
|
||||||
Increased log level from DEBUG to INFO in logging_config.py to reduce log verbosity. Server file handler now logs at INFO level instead of DEBUG.
|
- Removed `self.events.download_progress = None` from [src/core/providers/aniworld_provider.py](src/core/providers/aniworld_provider.py#L109)
|
||||||
|
- Removed `self._events.download_status = None` and `self._events.scan_status = None` from [src/core/SeriesApp.py](src/core/SeriesApp.py#L157-158)
|
||||||
|
|
||||||
|
The Events library requires that events are not initialized to None. After creating the `Events()` object, event attributes are automatically handled by the library and can be subscribed to immediately.
|
||||||
|
|
||||||
|
**Testing:**
|
||||||
|
- Verified event initialization works correctly for both AniworldLoader and SeriesApp
|
||||||
|
- Confirmed that event subscription works without errors
|
||||||
|
- Unit tests continue to pass (251 passed)
|
||||||
|
|
||||||
---
|
---
|
||||||
|
|
||||||
|
## TODO List:
|
||||||
|
|||||||
@ -154,8 +154,6 @@ class SeriesApp:
|
|||||||
|
|
||||||
# Initialize events
|
# Initialize events
|
||||||
self._events = Events()
|
self._events = Events()
|
||||||
self._events.download_status = None
|
|
||||||
self._events.scan_status = None
|
|
||||||
|
|
||||||
self.loaders = Loaders()
|
self.loaders = Loaders()
|
||||||
self.loader = self.loaders.GetLoader(key="aniworld.to")
|
self.loader = self.loaders.GetLoader(key="aniworld.to")
|
||||||
|
|||||||
@ -101,8 +101,6 @@ class AniworldLoader(Loader):
|
|||||||
# Events: download_progress is triggered with progress dict
|
# Events: download_progress is triggered with progress dict
|
||||||
self.events = Events()
|
self.events = Events()
|
||||||
|
|
||||||
self.events.download_progress = None
|
|
||||||
|
|
||||||
def subscribe_download_progress(self, handler):
|
def subscribe_download_progress(self, handler):
|
||||||
"""Subscribe a handler to the download_progress event.
|
"""Subscribe a handler to the download_progress event.
|
||||||
Args:
|
Args:
|
||||||
|
|||||||
Loading…
x
Reference in New Issue
Block a user