Rename sync_series_from_data_files to sync_legacy_series_to_db

- Rename function to reflect its legacy status
- Add deprecation warning log on execution
- Update all callers (initialization_service, api/config, fastapi_app)
- Update tests to use new name
- Add deprecation notice to DEVELOPMENT.md

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

src/server/api/config.py

@@ -284,9 +284,9 @@ async def update_directory(
         try:
             import structlog
 
-            from src.server.services.anime_service import sync_series_from_data_files
+            from src.server.services.anime_service import sync_legacy_series_to_db
             logger = structlog.get_logger(__name__)
-            sync_count = await sync_series_from_data_files(directory, logger)
+            sync_count = await sync_legacy_series_to_db(directory, logger)
             logger.info(
                 "Directory updated: synced series from data files",
                 directory=directory,

src/server/fastapi_app.py

@@ -38,7 +38,6 @@ from src.server.controllers.page_controller import router as page_router
 from src.server.middleware.auth import AuthMiddleware
 from src.server.middleware.error_handler import register_exception_handlers
 from src.server.middleware.setup_redirect import SetupRedirectMiddleware
-from src.server.services.anime_service import sync_series_from_data_files
 from src.server.services.progress_service import get_progress_service
 from src.server.services.websocket_service import get_websocket_service
 

src/server/services/anime_service.py

@@ -1554,19 +1554,17 @@ def get_anime_service(series_app: SeriesApp) -> AnimeService:
     return AnimeService(series_app)
 
 
-async def sync_series_from_data_files(
+async def sync_legacy_series_to_db(
     anime_directory: str,
     log_instance=None  # pylint: disable=unused-argument
 ) -> int:
     """
-    Sync series from data files to the database.
+    One-time legacy sync: import any series from 'data' files
+    not already in the database.
 
-    Scans the anime directory for data files and adds any new series
-    to the database. Existing series are skipped (no duplicates).
-
-    This function is typically called during application startup to ensure
-    series metadata stored in filesystem data files is available in the
-    database.
+    Deprecated: Series are now loaded directly from the database.
+    This function remains for backwards compatibility with legacy
+    file-based data during migration.
 
     Args:
         anime_directory: Path to the anime directory with data files
@@ -1578,6 +1576,11 @@ async def sync_series_from_data_files(
     """
     # Always use structlog for structured logging with keyword arguments
     log = structlog.get_logger(__name__)
+        
+    log.warning(
+        "sync_legacy_series_to_db is deprecated. "
+        "Series are now loaded directly from database."
+    )
 
     try:
         from src.server.database.connection import get_db_session

src/server/services/initialization_service.py

@@ -6,7 +6,7 @@ from typing import Callable, Optional
 import structlog
 
 from src.config.settings import settings
-from src.server.services.anime_service import sync_series_from_data_files
+from src.server.services.anime_service import sync_legacy_series_to_db
 from src.server.services.legacy_file_migration import migrate_series_from_files_to_db
 
 logger = structlog.get_logger(__name__)
@@ -170,7 +170,7 @@ async def _sync_anime_folders(progress_service=None) -> int:
             metadata={"step_id": "series_sync"}
         )
     
-    sync_count = await sync_series_from_data_files(settings.anime_directory)
+    sync_count = await sync_legacy_series_to_db(settings.anime_directory)
     logger.info("Data file sync complete. Added %d series.", sync_count)
     
     if progress_service: