From ebb0769ed4c93f0db7ca4cf74a7620dc190f78c4 Mon Sep 17 00:00:00 2001 From: Lukas Date: Wed, 22 Oct 2025 13:54:24 +0200 Subject: [PATCH] cleanup --- QualityTODO.md | 58 -------------------------------------------------- 1 file changed, 58 deletions(-) diff --git a/QualityTODO.md b/QualityTODO.md index 595564c..3687eeb 100644 --- a/QualityTODO.md +++ b/QualityTODO.md @@ -118,26 +118,11 @@ conda run -n AniWorld python -m pytest tests/ -v -s **Method/Function Docstrings** -- [ ] `src/cli/Main.py` - - `__InitList__()` - missing docstring (line 50) - - `display_series()` - missing docstring (line 60) - - `get_user_selection()` - missing docstring (line 75) - - `search()` - missing docstring (line 70) - - `retry()` - missing docstring - - `print_Download_Progress()` - missing docstring -- [ ] `src/core/SerieScanner.py` - - `is_null_or_whitespace()` - missing docstring (line 66) -- [ ] `src/core/providers/base_provider.py` - - All 6 abstract methods - missing docstrings explaining the contract -- [ ] `src/core/providers/streaming/Provider.py` - - `GetLink()` - missing docstring - [ ] `src/server/utils/logging.py` - Check helper functions - [ ] `src/server/utils/template_helpers.py` - Check helper functions #### Unclear Variable Names -- [ ] `src/cli/Main.py` line 122 - - `task3` is vague - should be `task_progress` or `download_progress_task` - [ ] `src/core/providers/enhanced_provider.py` line 35 - `rec` in dictionary - should be `rate_limit_record` - [ ] `src/core/SerieScanner.py` line 138 @@ -147,9 +132,6 @@ conda run -n AniWorld python -m pytest tests/ -v -s #### Unclear Comments or Missing Context -- [ ] `src/cli/Main.py` line 122 - German comment - - "Setze total auf 100 für Prozentanzeige" should be English - - Should be: "Set total to 100 for percentage display" - [ ] `src/core/providers/enhanced_provider.py` line 231 - Comment style inconsistent with rest of codebase - [ ] `src/server/api/download.py` line 51 @@ -611,8 +593,6 @@ conda run -n AniWorld python -m pytest tests/ -v -s #### `src/core/providers/enhanced_provider.py` -- [ ] **Import Issue**: Line 27 - `from error_handler import ...` - file doesn't exist in repository - - This will cause ImportError at runtime - [ ] **Type Hints**: Class constructor `__init__()` missing type annotations (lines 40-96) - [ ] **Documentation**: Bare exception handlers at lines 418-419 - need specific exception types - [ ] **Code Quality**: `with_error_recovery` decorator imported but usage unclear @@ -744,11 +724,6 @@ conda run -n AniWorld python -m pytest tests/ -v -s - [ ] **CORS Configuration** (`src/server/fastapi_app.py`, line 48) - `allow_origins=["*"]` is insecure for production - Add environment-based configuration -- [ ] **Missing Import Error** (`src/core/providers/enhanced_provider.py`, line 27) - - - `from error_handler import ...` file doesn't exist - - Will cause ImportError at runtime - - [ ] **Global Password State** (`src/server/services/auth_service.py`, line 51) - In-memory failure tracking resets on restart - Recommend using persistent storage (database/Redis) @@ -767,38 +742,6 @@ conda run -n AniWorld python -m pytest tests/ -v -s ## 📊 Code Style Issues -### Import Organization - -- [ ] `src/cli/Main.py` - imports not sorted -- [ ] `src/core/providers/aniworld_provider.py` - imports not sorted -- [ ] `src/core/providers/enhanced_provider.py` - imports not sorted - -### Missing Type Hints (Summary) - -- [ ] `src/cli/Main.py` - ~10 methods without type hints -- [ ] `src/core/providers/base_provider.py` - All 6 abstract methods -- [ ] `src/core/providers/streaming/Provider.py` - Return type invalid syntax -- [ ] `src/core/providers/aniworld_provider.py` - Constructor and attributes -- [ ] `src/server/api/anime.py` - Several endpoint methods -- [ ] `src/server/utils/dependencies.py` - Several dependency functions - -### Documentation Gaps - -- [ ] Missing comprehensive module docstrings in several files -- [ ] Abstract method contracts not documented -- [ ] Complex algorithms need inline comments - ---- - -## 🎯 Specific Task Items - -### Import/Module Issues - -- [ ] Fix missing `error_handler` module import in `src/core/providers/enhanced_provider.py` -- [ ] Sort imports in `src/cli/Main.py` using isort -- [ ] Sort imports in `src/core/providers/aniworld_provider.py` using isort -- [ ] Sort imports in `src/core/providers/enhanced_provider.py` using isort - ### Documentation - Phase 1: Critical Sections - [ ] Document database transaction behavior in `src/server/database/service.py` @@ -831,7 +774,6 @@ conda run -n AniWorld python -m pytest tests/ -v -s ### Security - Phase 1: Critical Fixes -- [ ] Fix missing `error_handler` import error in `src/core/providers/enhanced_provider.py` - [ ] Make CORS configuration environment-based in `src/server/fastapi_app.py` - [ ] Add startup validation to ensure `anime_directory` is configured