refactor: Apply PEP8 naming conventions - convert PascalCase methods to snake_case
This comprehensive refactoring applies PEP8 naming conventions across the codebase: ## Core Changes: ### src/cli/Main.py - Renamed __InitList__() to __init_list__() - Renamed print_Download_Progress() to print_download_progress() - Fixed variable naming: task3 -> download_progress_task - Fixed parameter spacing: words :str -> words: str - Updated all method calls to use snake_case - Added comprehensive docstrings ### src/core/SerieScanner.py - Renamed Scan() to scan() - Renamed GetTotalToScan() to get_total_to_scan() - Renamed Reinit() to reinit() - Renamed private methods to snake_case: - __ReadDataFromFile() -> __read_data_from_file() - __GetMissingEpisodesAndSeason() -> __get_missing_episodes_and_season() - __GetEpisodeAndSeason() -> __get_episode_and_season() - __GetEpisodesAndSeasons() -> __get_episodes_and_seasons() - Added comprehensive docstrings to all methods - Fixed long line issues ### src/core/providers/base_provider.py - Refactored abstract base class with proper naming: - Search() -> search() - IsLanguage() -> is_language() - Download() -> download() - GetSiteKey() -> get_site_key() - GetTitle() -> get_title() - Added proper type hints (Dict, List, etc.) - Added comprehensive docstrings explaining contracts - Fixed newline at end of file ### src/core/providers/aniworld_provider.py - Renamed public methods to snake_case: - Search() -> search() - IsLanguage() -> is_language() - Download() -> download() - GetSiteKey() -> get_site_key() - GetTitle() -> get_title() - ClearCache() -> clear_cache() - RemoveFromCache() -> remove_from_cache() - Renamed private methods to snake_case: - _GetLanguageKey() -> _get_language_key() - _GetKeyHTML() -> _get_key_html() - _GetEpisodeHTML() -> _get_episode_html() - Fixed import organization - Improved code formatting and line lengths - Added docstrings to all methods ### src/core/SeriesApp.py - Updated all calls to use new snake_case method names - Updated loader calls: loader.Search() -> loader.search() - Updated loader calls: loader.Download() -> loader.download() - Updated scanner calls: SerieScanner.GetTotalToScan() -> SerieScanner.get_total_to_scan() - Updated scanner calls: SerieScanner.Reinit() -> SerieScanner.reinit() - Updated scanner calls: SerieScanner.Scan() -> SerieScanner.scan() ### tests/unit/test_series_app.py - Updated mock calls to use new snake_case method names: - get_total_to_scan() instead of GetTotalToScan() - reinit() instead of Reinit() - scan() instead of Scan() ## Verification: - All unit tests pass ✅ - All integration tests pass ✅ - All tests pass ✅ - No breaking changes to functionality ## Standards Applied: - PEP 8: Function/method names use lowercase with underscores (snake_case) - PEP 257: Added comprehensive docstrings - Type hints: Proper type annotations where applicable - Code formatting: Fixed line lengths and spacing
This commit is contained in:
@@ -281,9 +281,9 @@ class TestSeriesAppReScan:
|
||||
app = SeriesApp(test_dir)
|
||||
|
||||
# Mock scanner
|
||||
app.SerieScanner.GetTotalToScan = Mock(return_value=5)
|
||||
app.SerieScanner.Reinit = Mock()
|
||||
app.SerieScanner.Scan = Mock()
|
||||
app.SerieScanner.get_total_to_scan = Mock(return_value=5)
|
||||
app.SerieScanner.reinit = Mock()
|
||||
app.SerieScanner.scan = Mock()
|
||||
|
||||
# Perform rescan
|
||||
result = app.ReScan()
|
||||
@@ -293,8 +293,8 @@ class TestSeriesAppReScan:
|
||||
assert "completed" in result.message.lower()
|
||||
# After successful completion, finally block resets operation
|
||||
assert app._current_operation is None
|
||||
app.SerieScanner.Reinit.assert_called_once()
|
||||
app.SerieScanner.Scan.assert_called_once()
|
||||
app.SerieScanner.reinit.assert_called_once()
|
||||
app.SerieScanner.scan.assert_called_once()
|
||||
|
||||
@patch('src.core.SeriesApp.Loaders')
|
||||
@patch('src.core.SeriesApp.SerieScanner')
|
||||
|
||||
Reference in New Issue
Block a user