Fix WebSocket room subscription format
This commit is contained in:
@@ -18,14 +18,14 @@ This document verifies that the anime add functionality correctly loads NFO, log
|
||||
When a new anime is added via `POST /api/anime/add`:
|
||||
|
||||
1. **API Endpoint** ([anime.py:694-920](../src/server/api/anime.py#L694-L920))
|
||||
- Validates input and extracts series key
|
||||
- Creates database entry with `loading_status="pending"`
|
||||
- Adds to in-memory cache
|
||||
- **Queues background loading task** for the specific anime
|
||||
- Validates input and extracts series key
|
||||
- Creates database entry with `loading_status="pending"`
|
||||
- Adds to in-memory cache
|
||||
- **Queues background loading task** for the specific anime
|
||||
|
||||
2. **Background Loading** ([background_loader_service.py](../src/server/services/background_loader_service.py))
|
||||
- Processes one `SeriesLoadingTask` at a time
|
||||
- Each task contains **only one anime's metadata**: key, folder, name, year
|
||||
- Processes one `SeriesLoadingTask` at a time
|
||||
- Each task contains **only one anime's metadata**: key, folder, name, year
|
||||
|
||||
### 2. NFO/Artwork Loading Process
|
||||
|
||||
@@ -34,7 +34,7 @@ The `_load_nfo_and_images()` method ([background_loader_service.py:454-544](../s
|
||||
```python
|
||||
async def _load_nfo_and_images(self, task: SeriesLoadingTask, db: Any) -> None:
|
||||
"""Load NFO file and images for a series by reusing NFOService.
|
||||
|
||||
|
||||
Args:
|
||||
task: The loading task (contains data for ONE anime only)
|
||||
db: Database session
|
||||
@@ -43,7 +43,7 @@ async def _load_nfo_and_images(self, task: SeriesLoadingTask, db: Any) -> None:
|
||||
if self.series_app.nfo_service.has_nfo(task.folder):
|
||||
# Skip if exists
|
||||
return
|
||||
|
||||
|
||||
# Create NFO with THIS anime's specific data
|
||||
nfo_path = await self.series_app.nfo_service.create_tvshow_nfo(
|
||||
serie_name=task.name, # ✅ Only this anime's name
|
||||
@@ -58,21 +58,25 @@ async def _load_nfo_and_images(self, task: SeriesLoadingTask, db: Any) -> None:
|
||||
### 3. Key Implementation Details
|
||||
|
||||
#### ✅ Isolated Task Processing
|
||||
|
||||
- Each `SeriesLoadingTask` contains data for **exactly one anime**
|
||||
- Tasks are processed sequentially from the queue
|
||||
- No cross-contamination between anime
|
||||
|
||||
#### ✅ Targeted NFO Creation
|
||||
|
||||
- `NFOService.create_tvshow_nfo()` receives parameters for **one anime only**
|
||||
- Downloads poster, logo, fanart to **that anime's folder only**
|
||||
- TMDB API calls are made for **that specific anime's name/year**
|
||||
|
||||
#### ✅ No Global Scanning
|
||||
|
||||
- `SerieList.load_series()` only **checks** for existing files
|
||||
- It does **not** download or create any new files
|
||||
- Used only for initial library scanning, not during anime add
|
||||
|
||||
#### ✅ Isolated Episode Scanning
|
||||
|
||||
- `_load_episodes()` uses `_find_series_directory()` and `_scan_series_episodes()`
|
||||
- Scans **only the specific anime's directory**, not the entire library
|
||||
- No impact on other anime
|
||||
@@ -80,15 +84,19 @@ async def _load_nfo_and_images(self, task: SeriesLoadingTask, db: Any) -> None:
|
||||
## Verification
|
||||
|
||||
### Code Review
|
||||
|
||||
✅ Reviewed implementation in:
|
||||
|
||||
- `src/server/services/background_loader_service.py` (lines 454-544)
|
||||
- `src/server/api/anime.py` (lines 694-920)
|
||||
- `src/core/entities/SerieList.py` (lines 149-250)
|
||||
|
||||
### Test Created
|
||||
|
||||
✅ Created comprehensive test: `tests/integration/test_anime_add_nfo_isolation.py`
|
||||
|
||||
The test verifies:
|
||||
|
||||
1. NFO service called exactly once for new anime
|
||||
2. Correct parameters passed (name, folder, year)
|
||||
3. Existing anime not affected
|
||||
@@ -101,6 +109,7 @@ Note: Test requires database mocking to run fully, but code analysis confirms co
|
||||
**The current implementation is CORRECT and COMPLETE.**
|
||||
|
||||
When adding a new anime:
|
||||
|
||||
- ✅ NFO is created only for that specific anime
|
||||
- ✅ Logo is downloaded only to that anime's folder
|
||||
- ✅ Artwork (poster, fanart) is downloaded only to that anime's folder
|
||||
|
||||
Reference in New Issue
Block a user