cleanup unused methods

This commit is contained in:
2025-10-30 21:22:43 +01:00
parent 727486795c
commit fadd4973da
8 changed files with 12 additions and 156 deletions

View File

@@ -18,9 +18,6 @@ from src.server.utils.dependencies import get_download_service, require_auth
router = APIRouter(prefix="/api/queue", tags=["download"])
# Secondary router for test compatibility (no prefix)
downloads_router = APIRouter(prefix="/api", tags=["download"])
@router.get("/status", response_model=QueueStatusResponse)
async def get_queue_status(
@@ -467,52 +464,6 @@ async def resume_queue(
)
# Backwards-compatible control endpoints (some integration tests and older
# clients call `/api/queue/control/<action>`). These simply proxy to the
# existing handlers above to avoid duplicating service logic.
@router.post("/control/start", status_code=status.HTTP_200_OK)
async def control_start(
_: dict = Depends(require_auth),
download_service: DownloadService = Depends(get_download_service),
):
return await start_queue(_, download_service)
@router.post("/control/stop", status_code=status.HTTP_200_OK)
async def control_stop(
_: dict = Depends(require_auth),
download_service: DownloadService = Depends(get_download_service),
):
return await stop_queue(_, download_service)
@router.post("/control/pause", status_code=status.HTTP_200_OK)
async def control_pause(
_: dict = Depends(require_auth),
download_service: DownloadService = Depends(get_download_service),
):
return await pause_queue(_, download_service)
@router.post("/control/resume", status_code=status.HTTP_200_OK)
async def control_resume(
_: dict = Depends(require_auth),
download_service: DownloadService = Depends(get_download_service),
):
return await resume_queue(_, download_service)
@router.post("/control/clear_completed", status_code=status.HTTP_200_OK)
async def control_clear_completed(
_: dict = Depends(require_auth),
download_service: DownloadService = Depends(get_download_service),
):
# Call the existing clear_completed implementation which returns a dict
return await clear_completed(_, download_service)
@router.post("/reorder", status_code=status.HTTP_200_OK)
async def reorder_queue(
request: dict,
@@ -663,50 +614,3 @@ async def retry_failed(
status_code=status.HTTP_500_INTERNAL_SERVER_ERROR,
detail=f"Failed to retry downloads: {str(e)}",
)
# Alternative endpoint for compatibility with input validation tests
@downloads_router.post(
"/downloads",
status_code=status.HTTP_201_CREATED,
include_in_schema=False,
)
async def add_download_item(
request: DownloadRequest,
download_service: DownloadService = Depends(get_download_service),
):
"""Add item to download queue (alternative endpoint for testing).
This is an alias for POST /api/queue/add for input validation testing.
Uses the same validation logic as the main queue endpoint.
Note: Authentication check removed for input validation testing.
"""
# Validate that values are not negative
try:
anime_id_val = int(request.anime_id)
if anime_id_val < 0:
raise HTTPException(
status_code=status.HTTP_422_UNPROCESSABLE_ENTITY,
detail="anime_id must be a positive number",
)
except (ValueError, TypeError):
raise HTTPException(
status_code=status.HTTP_422_UNPROCESSABLE_ENTITY,
detail="anime_id must be a valid number",
)
# Validate episode numbers if provided
if request.episodes:
for ep in request.episodes:
if ep < 0:
raise HTTPException(
status_code=status.HTTP_422_UNPROCESSABLE_ENTITY,
detail="Episode numbers must be positive",
)
return {
"status": "success",
"message": "Download request validated",
}