lukas.pupkalipinski/Aniworld
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
350 Commits 1 Branch 0 Tags
Commit Graph

14 Commits

Author SHA1 Message Date
Lukas
2a85a2bc18 Fix permission error when copying files to network directory 
- Replace shutil.copy2() with shutil.copyfile() in enhanced_provider.py
- Replace shutil.copy() with shutil.copyfile() in aniworld_provider.py
- copyfile() only copies content, avoiding metadata permission issues
 2026-01-09 19:18:57 +01:00
Lukas
aeb1ebe7a2 Task 1.4: Update provider classes to use key as primary identifier 
- Enhanced download() method docstring in aniworld_provider.py
- Enhanced Download() method docstring in enhanced_provider.py
- Clarified that 'key' is the series unique identifier from provider
- Clarified that 'serie_folder'/'serieFolder' is filesystem folder name (metadata only)
- Added comprehensive Args, Returns, and Raises sections to docstrings
- Fixed PEP 8 line length issue in logging statement
- Verified existing code already uses 'key' for identification and logging
- All 34 provider-related tests pass successfully
- No functional changes required, documentation improvements only
 2025-11-23 17:51:32 +01:00
Lukas
ffb182e3ba cleanup 2025-10-23 19:41:24 +02:00
Lukas
c81a493fb1 cleanup 2025-10-23 19:00:49 +02:00
Lukas
3d5c19939c cleanup 2025-10-23 18:28:17 +02:00
Lukas
9a64ca5b01 cleanup 2025-10-23 18:10:34 +02:00
Lukas
5c2691b070 cleanup 2025-10-22 17:39:28 +02:00
Lukas
6db850c2ad cleanup 2025-10-22 15:54:36 +02:00
Lukas
92795cf9b3 Improve docs and security defaults 2025-10-22 15:22:58 +02:00
Lukas
7437eb4c02 refactor: improve code quality - fix imports, type hints, and security issues 
## Critical Fixes
- Create error_handler module with custom exceptions and recovery strategies
  - Adds RetryableError, NonRetryableError, NetworkError, DownloadError
  - Implements with_error_recovery decorator for automatic retry logic
  - Provides RecoveryStrategies and FileCorruptionDetector classes
  - Fixes critical import error in enhanced_provider.py

- Fix CORS security vulnerability in fastapi_app.py
  - Replace allow_origins=['*'] with environment-based config
  - Use settings.cors_origins for production configurability
  - Add security warnings in code comments

## Type Hints Improvements
- Fix invalid type hint syntax in Provider.py
  - Change (str, [str]) to tuple[str, dict[str, Any]]
  - Rename GetLink() to get_link() (PEP8 compliance)
  - Add comprehensive docstrings for abstract method

- Update streaming provider implementations
  - voe.py: Add full type hints, update method signature
  - doodstream.py: Add full type hints, update method signature
  - Fix parameter naming (embededLink -> embedded_link)
  - Both now return tuple with headers dict

- Enhance base_provider.py documentation
  - Add comprehensive type hints to all abstract methods
  - Add detailed parameter documentation
  - Add return type documentation with examples

## Files Modified
- Created: src/core/error_handler.py (error handling infrastructure)
- Modified: 9 source files (type hints, naming, imports)
- Added: QUALITY_IMPROVEMENTS.md (implementation details)
- Added: TEST_VERIFICATION_REPORT.md (test status)
- Updated: QualityTODO.md (progress tracking)

## Testing
- All tests passing (unit, integration, API)
- No regressions detected
- All 10+ type checking violations resolved
- Code follows PEP8 and PEP257 standards

## Quality Metrics
- Import errors: 1 -> 0
- CORS security: High Risk -> Resolved
- Type hint errors: 12+ -> 0
- Abstract method docs: Minimal -> Comprehensive
- Test coverage: Maintained with no regressions
 2025-10-22 13:00:09 +02:00
Lukas
80507119b7 fix: resolve line length violations (80+ characters) 
- refactor src/cli/Main.py: split long logging config, user prompts, and method calls
- refactor src/config/settings.py: break long Field definitions into multiple lines
- refactor src/core/providers/enhanced_provider.py: split provider lists, headers, and long f-strings
- refactor src/core/providers/streaming/voe.py: format HTTP header setup
- update QualityTODO.md: mark all line length violations as completed

All files now comply with 88-character line limit. Code readability improved with
better-structured multi-line statements and intermediate variables for complex expressions.
 2025-10-22 12:16:41 +02:00
Lukas
7a71715183 backup 2025-10-12 18:05:31 +02:00
Lukas Pupka-Lipinski
85f2d2c6f7 cleanup 2 2025-10-05 22:22:04 +02:00
Lukas Pupka-Lipinski
e477780ed6 refactoring 2025-09-29 21:18:42 +02:00