Commit Graph

3 Commits

Author SHA1 Message Date
51b7f349f8 fix(scheduler): strip null legacy alias fields from config.json on save
SchedulerConfig.__init__ maps legacy auto_download/folder_scan keys to the
primary auto_download_after_rescan/folder_scan_enabled fields. However,
model_dump() was including auto_download=null and folder_scan=null in
serialised output. When this was written to config.json and reloaded,
those keys were present (albeit null), so the alias mapping was skipped
and the primary fields retained default False values instead of the
configured True values.

Fix:
- Override SchedulerConfig.model_dump() to drop None-valued alias fields
  before returning the serialised dict.
- ConfigService.save_config() re-serialises the scheduler field through
  its overridden model_dump() so the fix applies when writing to disk.

Tests added:
- test_roundtrip_excludes_none_alias_fields: verifies model_dump omits
  null auto_download/folder_scan keys.
- test_save_and_load_scheduler_flags_roundtrip: end-to-end roundtrip
  through ConfigService confirms raw JSON and loaded values match.

Pre-existing failure in test_core_error_handler.py is unrelated.
2026-05-28 21:18:16 +02:00
842f9c88eb migration removed 2025-12-10 21:12:34 +01:00
0d6cade56c feat: Add comprehensive configuration persistence system
- Implemented ConfigService with file-based JSON persistence
  - Atomic file writes using temporary files
  - Configuration validation with detailed error reporting
  - Schema versioning with migration support
  - Singleton pattern for global access

- Added backup management functionality
  - Automatic backup creation before updates
  - Manual backup creation with custom names
  - Backup restoration with pre-restore backup
  - Backup listing and deletion
  - Automatic cleanup of old backups (max 10)

- Updated configuration API endpoints
  - GET /api/config - Retrieve configuration
  - PUT /api/config - Update with automatic backup
  - POST /api/config/validate - Validation without applying
  - GET /api/config/backups - List all backups
  - POST /api/config/backups - Create manual backup
  - POST /api/config/backups/{name}/restore - Restore backup
  - DELETE /api/config/backups/{name} - Delete backup

- Comprehensive test coverage
  - 27 unit tests for ConfigService (all passing)
  - Integration tests for API endpoints
  - Tests for validation, persistence, backups, and error handling

- Updated documentation
  - Added ConfigService documentation to infrastructure.md
  - Marked task as completed in instructions.md

Files changed:
- src/server/services/config_service.py (new)
- src/server/api/config.py (refactored)
- tests/unit/test_config_service.py (new)
- tests/api/test_config_endpoints.py (enhanced)
- infrastructure.md (updated)
- instructions.md (updated)
2025-10-17 20:26:40 +02:00