Commit Graph

172 Commits

Author SHA1 Message Date
611798b786 fix: handle lifespan errors gracefully
- Add error tracking in lifespan context manager
- Only cleanup services that were successfully initialized
- Properly handle startup errors without breaking async context
- Fixes RuntimeError: generator didn't stop after athrow()
2026-01-23 17:13:30 +01:00
314f535446 Complete initialization restart protection task 2026-01-23 16:38:13 +01:00
a8011eb6a3 Document initialization restart protection as completed 2026-01-23 16:36:36 +01:00
168b4c5ac4 Revert initialization_completed - use initial_scan_completed instead 2026-01-23 16:35:10 +01:00
925f408699 Update instructions with completed tasks 2026-01-23 16:26:48 +01:00
9fb93794e6 Fix async generator exception handling in database dependencies 2026-01-23 16:25:52 +01:00
faac14346f Fix async generator exception handling in get_optional_database_session 2026-01-23 16:06:42 +01:00
f8634bf605 Fix WebSocket room subscription format 2026-01-23 15:25:47 +01:00
7bf02ac8f8 Update instructions with completed tasks 2026-01-23 15:18:32 +01:00
33406fef1a Add NFO loading isolation verification document 2026-01-23 15:01:05 +01:00
5e233bcba0 Verify NFO/artwork loading isolation for anime add
- Confirmed BackgroundLoaderService loads NFO only for specific anime
- NFOService.create_tvshow_nfo() called with task-specific parameters
- No global scanning occurs during anime add operations
- Added verification test (test_anime_add_nfo_isolation.py)
- Updated instructions.md to mark task as completed
2026-01-23 15:00:36 +01:00
125892abe5 feat: implement NFO ID storage and media scan tracking
Task 3 (NFO data):
- Add parse_nfo_ids() method to NFOService
- Extract TMDB/TVDB IDs from NFO files during scan
- Update database with extracted IDs
- Add comprehensive unit and integration tests

Task 4 (Media scan):
- Track initial media scan with SystemSettings flag
- Run background loading only on first startup
- Skip media scan on subsequent runs
2026-01-21 19:36:54 +01:00
050db40af3 Mark task 2 (NFO scan) as completed 2026-01-21 19:25:48 +01:00
9f1158b9af Implement initial NFO scan tracking for one-time setup
- Add NFO scanning to startup process (fastapi_app.py)
- Check initial_nfo_scan_completed flag before running NFO scan
- Run NFO scan only on first startup if TMDB API key is configured
- Mark NFO scan as completed after first successful run
- Skip NFO scan on subsequent startups

This ensures NFO metadata processing only occurs during initial setup,
not on every application restart, improving startup performance.
2026-01-21 19:25:30 +01:00
db7e21a14c Mark task 1 as completed in instructions 2026-01-21 19:23:04 +01:00
bf3cfa00d5 Implement initial scan tracking for one-time setup
- Add SystemSettings model to track setup completion status
- Create SystemSettingsService for managing setup flags
- Modify fastapi_app startup to check and set initial_scan_completed flag
- Anime folder scanning now only runs on first startup
- Update DATABASE.md with new system_settings table documentation
- Add unit test for SystemSettingsService functionality

This ensures expensive one-time operations like scanning the entire anime
directory only occur during initial setup, not on every application restart.
2026-01-21 19:22:50 +01:00
b2379e05cf fix: Anime list endpoint now returns data correctly
- Root cause: Server needed restart to complete initialization
- Startup process syncs data files to DB and loads into memory
- Verified: GET /api/anime returns 192 anime with full metadata
2026-01-21 18:58:24 +01:00
f9e4970615 Add development session checklist - all objectives complete 2026-01-19 20:58:14 +01:00
5aba36c40a Add comprehensive issues resolution summary documentation 2026-01-19 20:57:23 +01:00
d425d711bd Add documentation for episode loading optimization 2026-01-19 20:56:31 +01:00
6215477eef Optimize episode loading to prevent full directory rescans
- Added _find_series_directory() to locate series without full rescan
- Added _scan_series_episodes() to scan only target series directory
- Modified _load_episodes() to use targeted scanning instead of anime_service.rescan()
- Added 15 comprehensive unit tests for optimization
- Performance improvement: <1s vs 30-60s for large libraries
- All tests passing (15 new tests + 14 existing background loader tests)
2026-01-19 20:55:48 +01:00
0b580f2fab Update instructions - all issues resolved 2026-01-19 20:45:36 +01:00
01f828c799 Fix NFO service year extraction from series names 2026-01-19 20:42:04 +01:00
6d40ddbfe5 Fix async generator exception handling and add comprehensive tests 2026-01-19 20:34:06 +01:00
d6a82f4329 Format updates to instructions and test file
- Improve markdown formatting in instructions.md
- Reorder imports in test_background_loader_session.py per PEP8
2026-01-19 20:06:03 +01:00
7d95c180a9 Fix async context manager usage in BackgroundLoaderService
- Changed 'async for' to 'async with' for get_db_session()
- get_db_session() is @asynccontextmanager, requires async with not async for
- Created 5 comprehensive unit tests verifying the fix
- All tests pass, background loading now works correctly
2026-01-19 19:50:25 +01:00
62bdcf35cb Add unit tests for dependency exception handling
- Created test_dependency_exception_handling.py with 5 comprehensive tests
- Tests verify proper handling of HTTPException in async generator dependencies
- All tests pass, confirming fix for 'generator didn't stop after athrow()' error
- Updated instructions with complete task documentation
2026-01-19 19:44:48 +01:00
c97da7db2e Update instructions with completed task 2026-01-19 19:39:41 +01:00
09a5eccea7 Fix generator exception handling in database dependencies
- Add proper exception handling in get_database_session and get_optional_database_session
- Prevents 'generator didn't stop after athrow()' error when HTTPException is raised
- Add mock for BackgroundLoaderService in anime endpoint tests
- Update test expectations to match 202 Accepted response for async add_series endpoint
2026-01-19 19:38:53 +01:00
265d7fe435 Update instructions.md with manual testing results and bug fixes 2026-01-19 08:49:59 +01:00
0bbdd46fc7 Fix async loading bugs and add test results
Critical Fixes:
- Fix async context manager usage in fastapi_app.py (async for -> async with)
- Add broadcast() method to WebSocketService
- Initialize BackgroundLoaderService properly in lifespan function

Testing:
- Execute manual testing (Tests 1, 5, 8, 9)
- Create comprehensive test results document
- Verify API endpoints return 202 Accepted
- Confirm database persistence works
- Validate startup incomplete series check

Test Results:
- Response time: 61ms (target: < 500ms) 
- 4 series found with missing data on startup
- Database fields properly persisted
- All critical bugs fixed

Files:
- check_db.py: Database inspection utility
- docs/MANUAL_TESTING_RESULTS.md: Comprehensive test results
- src/server/fastapi_app.py: Fixed async context manager, initialized BackgroundLoaderService
- src/server/services/websocket_service.py: Added broadcast() method
2026-01-19 08:49:28 +01:00
8b0a4abca9 Add comprehensive manual testing guide for async loading
- Create detailed testing guide with 10 test scenarios
- Include step-by-step instructions and expected results
- Add troubleshooting section and verification checklist
- Provide performance metrics template
- Update instructions.md with testing information
2026-01-19 07:36:24 +01:00
5ca6a27573 Update instructions with final implementation status
- Mark async series loading task as completed
- Document test coverage (10/10 unit, 4/9 integration)
- List all created and modified files
- Note remaining manual testing needed
2026-01-19 07:27:31 +01:00
0b4fb10d65 Add frontend UI for async series loading
- Add SERIES_LOADING_UPDATE WebSocket event
- Update series cards to display loading indicators
- Add real-time status updates via WebSocket
- Include progress tracking (episodes, NFO, logo, images)
- Add CSS styling for loading states
- Implement updateSeriesLoadingStatus function
2026-01-19 07:20:29 +01:00
f18c31a035 Implement async series data loading with background processing
- Add loading status fields to AnimeSeries model
- Create BackgroundLoaderService for async task processing
- Update POST /api/anime/add to return 202 Accepted immediately
- Add GET /api/anime/{key}/loading-status endpoint
- Integrate background loader with startup/shutdown lifecycle
- Create database migration script for loading status fields
- Add unit tests for BackgroundLoaderService (10 tests, all passing)
- Update AnimeSeriesService.create() to accept loading status fields

Architecture follows clean separation with no code duplication:
- BackgroundLoader orchestrates, doesn't reimplement
- Reuses existing AnimeService, NFOService, WebSocket patterns
- Database-backed status survives restarts
2026-01-19 07:14:55 +01:00
df19f8ad95 Docs: Update all documentation for series loading and episode tracking fixes 2026-01-18 16:10:34 +01:00
7a77dff194 Optimize startup: skip series loading on every SeriesApp init
- SeriesApp now passes skip_load=True to SerieList
- Prevents redundant data file loading on every startup
- Series loaded once during setup via sync_series_from_data_files()
- Removed obsolete _init_list_sync() and _init_list() methods
- Updated documentation in ARCHITECTURE.md and README.md
2026-01-18 15:36:48 +01:00
1b4526d050 Document NFO folder naming fix 2026-01-18 12:28:55 +01:00
491daa2e50 Fix NFO folder naming to include year
- Add Serie.ensure_folder_with_year() method to ensure folder names include year
- Update all NFO API endpoints to call ensure_folder_with_year() before operations
- Folder format is now 'Name (Year)' when year is available
- Add comprehensive tests for ensure_folder_with_year() method
- All 5 tests passing
2026-01-18 12:28:38 +01:00
03901a8c2d Document NFO JavaScript JSON parsing fix 2026-01-18 12:18:58 +01:00
c92e2d340e Fix JSON parsing in NFO JavaScript modules
- Add response.json() calls in nfo-manager.js for all API calls
- Add response.json() calls in nfo-config.js for all API calls
- Fix createNFO, refreshNFO, viewNFO, getSeriesWithoutNFO functions
- Fix load and testTMDBConnection functions
- All API responses must be parsed before accessing properties
2026-01-18 12:18:42 +01:00
e502dcb8bd Fix NFO 503 error on server reload with config fallback
- Add dynamic config loading in get_nfo_service() dependency
- Handle settings reset during uvicorn reload in development
- Add comprehensive tests for settings priority and fallback behavior
- All 4 unit tests passing (settings priority, config fallback, error cases)
- Update documentation with reload scenario fix
2026-01-18 12:16:05 +01:00
4e56093ff9 Fix NFO creation 500 error for missing folders
- Auto-create series folder if it doesn't exist
- Add unit and integration tests for folder creation
- NFO creation now works for newly added series
2026-01-18 12:07:37 +01:00
9877f9400c Fix NFO service 503 error
- Load TMDB API key and NFO settings from config.json
- Sync NFO config to settings during app startup
- NFO endpoints now work correctly (no more 503)
2026-01-18 11:59:57 +01:00
db1e7fa54b Fix NFO database query errors
- Fixed async context manager issue in anime.py (use get_sync_session)
- Fixed async methods in anime_service.py to use async with
- Fixed folder_name attribute error (should be folder)
- All three methods now properly handle database sessions
2026-01-18 11:56:22 +01:00
4408874d37 backup 2026-01-17 22:56:38 +01:00
390cafc0dc Update documentation formatting and content
- Fix indentation in instructions.md for better readability
- Update docs/pp.txt content
2026-01-17 22:50:58 +01:00
c6919ac124 Add comprehensive NFO and media download tests
- Add 23 new unit tests for media downloads in test_nfo_service.py
- Create test_nfo_integration.py with 10 integration tests
- Test all media download scenarios (poster/logo/fanart)
- Test various image sizes and configurations
- Test concurrent NFO operations
- Test error handling and edge cases
- All 44 NFO service tests passing
- All 10 integration tests passing
2026-01-17 22:18:54 +01:00
22a41ba93f Add German FSK rating support for NFO files
- Add optional fsk field to TVShowNFO model
- Implement TMDB content ratings API integration
- Add FSK extraction and mapping (FSK 0/6/12/16/18)
- Update XML generation to prefer FSK over MPAA
- Add nfo_prefer_fsk_rating config setting
- Add 31 comprehensive tests for FSK functionality
- All 112 NFO tests passing
2026-01-17 22:13:34 +01:00
fd5e85d5ea Add recent updates section to features.md 2026-01-17 18:01:28 +01:00