Aniworld/Docs/tasks.md at 4687a06374a9f87089b8cbb932d932ff0e4fc6b2

Files

Lukas 4687a06374 Refactor trigger_rescan to use anime_service

- Use anime_service.rescan() instead of direct trigger_rescan import
- Change Optional[Any] to Optional[Dict[str, Any]] in ConfigUpdate for better type hints
- Add ValidationError handling in ConfigUpdate.apply_to
- Update tests to match new implementation

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

2026-06-27 15:46:22 +02:00

13 KiB

Raw Blame History

Task 14: Invalid Schedule Time — Should reject malformed schedule_time with 422

Test Result: FAIL — Url: http://127.0.0.1:8765/api/scheduler/config Expected status: 422 != 200

Instructions: The Invalid Schedule Time API test sends a malformed schedule_time and expects a 422 Unprocessable Entity, but the server returns 200 OK. Review the scheduler config validation. The endpoint should reject malformed schedule times (e.g., invalid format, out-of-range values) and return 422.

Task 15: Invalid Schedule Days — Should reject invalid day abbreviations with 422

Test Result: FAIL — Url: http://127.0.0.1:8765/api/scheduler/config Expected status: 422 != 200

Instructions: The Invalid Schedule Days API test sends invalid day abbreviations and expects a 422 Unprocessable Entity, but the server returns 200 OK. Review the scheduler config validation for schedule_days. The endpoint should reject invalid day values and return 422.

Task 16: Empty Schedule Days — Should reject empty schedule_days with 422

Test Result: FAIL — Url: http://127.0.0.1:8765/api/scheduler/config Expected status: 422 != 200

Instructions: The Empty Schedule Days API test sends an empty schedule_days value and expects a 422 Unprocessable Entity, but the server returns 200 OK. Review the scheduler config validation. The endpoint should reject empty schedule_days and return 422.

Task 17: List Unresolved Folders — Should return non-empty list when folders exist

Test Result: FAIL — '[]' should not be empty

Instructions: The List Unresolved Folders API test expects a non-empty list of unresolved folders, but gets []. Review the endpoint that lists unresolved folders. Ensure that when there are folders in the anime directory that do not match any known series, they are returned by this endpoint. Check if the folder detection logic is working correctly.

Task 18: Get Unresolved Folder Details — Endpoint should exist

Test Result: FAIL — Url: http://127.0.0.1:8765/api/setup/unresolved/SomeFolder Expected status: 404 != 200

Instructions: The Get Unresolved Folder Details API test expects a 200 OK from /api/setup/unresolved/{folder}, but gets 404 Not Found. The endpoint does not exist or the route is incorrect. Implement or fix the route so it returns details for a specific unresolved folder.

Task 19: Resolve Folder With Provider Key — Endpoint should exist

Test Result: FAIL — Url: http://127.0.0.1:8765/api/setup/unresolved/SomeFolder/resolve Expected status: 404 != 200

Instructions: The Resolve Folder With Provider Key API test expects a 200 OK from /api/setup/unresolved/{folder}/resolve, but gets 404 Not Found. The endpoint does not exist or the route is incorrect. Implement or fix the route so it accepts a provider key and resolves the folder to a series.

Task 20: Connect To WebSocket — WebSocket keyword library missing

Test Result: FAIL — No keyword with name 'Connect To WebSocket' found

Instructions: The Connect To WebSocket test fails because the custom keyword library tests/robot/resources/websocket_keywords.py contains no keywords. Implement the missing keywords in that file, or add the required WebSocket connection keyword using the Browser library or a custom Python library.

Task 21: Anime Settings Page Loads — Settings section should be visible

Test Result: FAIL — TimeoutError: locator.waitFor: Timeout 5000ms exceeded. waiting for locator('id=settings-section') to be visible

Instructions: The Anime Settings Page Loads UI test expects the #settings-section element to be visible, but it remains hidden (class="settings-section hidden"). Review the anime settings page frontend code. Ensure that when navigating to the anime settings page, the settings section is shown (the hidden class is removed or the element is otherwise made visible).

Task 22: Regenerate NFO — Settings section should be visible

Test Result: FAIL — TimeoutError: locator.waitFor: Timeout 5000ms exceeded. waiting for locator('id=settings-section') to be visible

Instructions: Same root cause as Task 21. The #settings-section element is hidden when the test tries to interact with it during the NFO regeneration flow. Fix the anime settings page visibility logic so the settings section is shown when the page loads.

Task 23: Update Series Settings — Settings section should be visible

Test Result: FAIL — TimeoutError: locator.waitFor: Timeout 5000ms exceeded. waiting for locator('id=settings-section') to be visible

Instructions: Same root cause as Task 21. The #settings-section element is hidden when the test tries to update series settings. Fix the anime settings page visibility logic so the settings section is shown when the page loads.

Task 24: Show Missing Episodes Only — Scan overlay should not block clicks

Test Result: FAIL — TimeoutError: locator.click: Timeout 10000ms exceeded. <div id="scan-progress-overlay" class="scan-progress-overlay visible"> intercepts pointer events

Instructions: The Show Missing Episodes Only UI test tries to click the #show-missing-only button, but the scan progress overlay intercepts pointer events. Review the dashboard frontend. Ensure the scan overlay either: (a) hides itself when scanning is complete, (b) allows clicks to pass through to underlying elements, or (c) is not shown when there is no active scan.

Task 25: Download Selected — Toast should mention queue

Test Result: FAIL — 'Mit Server verbunden' does not contain 'queue'

Instructions: The Download Selected UI test expects a toast/notification message containing the word queue, but sees 'Mit Server verbunden' (German for "Connected to server"). Review the download selected action. Ensure that when episodes are added to the download queue, the success toast message explicitly mentions "queue" so the test can verify the action.

Test Result: FAIL — 'invalid credentials' does not contain 'lockout'

Instructions: The Login Rate Limit UI test expects the login form to display a message containing lockout after repeated failed attempts, but it shows 'invalid credentials' instead. Review the login frontend and backend rate-limiting logic. After exceeding the allowed number of failed attempts, the UI should display a lockout message (e.g., "Account locked, try again in X minutes") instead of the generic "invalid credentials" message.

Test Result: FAIL — TimeoutError: locator.click: Timeout 10000ms exceeded. waiting for locator('id=config-modal .modal-overlay')

Instructions: The Close Settings Modal Via Overlay UI test tries to click the settings modal overlay to close it, but the click times out. Review the settings modal component. Ensure clicking the modal overlay (the dark background outside the modal content) triggers the modal to close.

Test Result: FAIL — TimeoutError: locator.waitFor: Timeout 3000ms exceeded. waiting for locator('id=config-modal') to be hidden

Instructions: The Close Settings Modal Via Escape UI test presses the Escape key and expects the #config-modal to be hidden, but it remains visible. Review the settings modal component. Add an Escape key event listener that closes the modal when the user presses Escape.

Task 29: Disable Scheduler — Checkbox should be visible and clickable

Test Result: FAIL — TimeoutError: locator.uncheck: Timeout 10000ms exceeded. waiting for locator('id=scheduled-rescan-enabled') element is not visible

Instructions: The Disable Scheduler UI test tries to uncheck the #scheduled-rescan-enabled checkbox, but it is not visible. Review the settings modal scheduler tab. Ensure the scheduler checkbox is visible when the scheduler settings tab is active, or that the test navigates to the correct tab before interacting with the checkbox.

Task 30: Edit Backup Settings — Checkbox should be visible and clickable

Test Result: FAIL — TimeoutError: locator.check: Timeout 10000ms exceeded. waiting for locator('id=backup-enabled') element is not visible

Instructions: The Edit Backup Settings UI test tries to check the #backup-enabled checkbox, but it is not visible. Review the settings modal backup tab. Ensure the backup settings form is visible when the backup tab is active, or that the test navigates to the correct tab before interacting with the checkbox.

Task 31: Edit NFO Settings — Checkbox should be visible and clickable

Test Result: FAIL — TimeoutError: locator.check: Timeout 10000ms exceeded. waiting for locator('id=nfo-auto-create') element is not visible

Instructions: The Edit NFO Settings UI test tries to check the #nfo-auto-create checkbox, but it is not visible. Review the settings modal NFO tab. Ensure the NFO settings form is visible when the NFO tab is active, or that the test navigates to the correct tab before interacting with the checkbox.