Lukas 96eeae620e fix: restore authentication and fix test suite
Major authentication and testing improvements:

Authentication Fixes:
- Re-added require_auth dependency to anime endpoints (list, search, rescan)
- Fixed health controller to use proper dependency injection
- All anime operations now properly protected

Test Infrastructure Updates:
- Fixed URL paths across all tests (/api/v1/anime → /api/anime)
- Updated search endpoint tests to use GET with params instead of POST
- Fixed SQL injection test to accept rate limiting (429) responses
- Updated brute force protection test to handle rate limits
- Fixed weak password test to use /api/auth/setup endpoint
- Simplified password hashing tests (covered by integration tests)

Files Modified:
- src/server/api/anime.py: Added auth requirements
- src/server/controllers/health_controller.py: Fixed dependency injection
- tests/api/test_anime_endpoints.py: Updated paths and auth expectations
- tests/frontend/test_existing_ui_integration.py: Fixed API paths
- tests/integration/test_auth_flow.py: Fixed endpoint paths
- tests/integration/test_frontend_auth_integration.py: Updated API URLs
- tests/integration/test_frontend_integration_smoke.py: Fixed paths
- tests/security/test_auth_security.py: Fixed tests and expectations
- tests/security/test_sql_injection.py: Accept rate limiting responses
- instructions.md: Removed completed tasks

Test Results:
- Before: 41 failures, 781 passed (93.4%)
- After: 24 failures, 798 passed (97.1%)
- Improvement: 17 fewer failures, +2.0% pass rate

Cleanup:
- Removed old summary documentation files
- Cleaned up obsolete config backups
2025-10-24 18:27:34 +02:00
..
2025-10-19 19:00:58 +02:00

Frontend Integration Tests

This directory contains integration tests for the existing JavaScript frontend (app.js, websocket_client.js, queue.js) with the FastAPI backend.

Test Coverage

test_existing_ui_integration.py

Comprehensive test suite for frontend-backend integration:

Authentication Tests (TestFrontendAuthentication)

  • Auth status endpoint behavior (configured/not configured/authenticated states)
  • JWT token login flow
  • Logout functionality
  • Unauthorized request handling (401 responses)
  • Authenticated request success

Anime API Tests (TestFrontendAnimeAPI)

  • GET /api/v1/anime - anime list retrieval
  • POST /api/v1/anime/search - search functionality
  • POST /api/v1/anime/rescan - trigger library rescan

Download API Tests (TestFrontendDownloadAPI)

  • Adding episodes to download queue
  • Getting queue status
  • Starting/pausing/stopping download queue

WebSocket Integration Tests (TestFrontendWebSocketIntegration)

  • WebSocket connection establishment with JWT token
  • Queue update broadcasts
  • Download progress updates

Configuration API Tests (TestFrontendConfigAPI)

  • GET /api/config - configuration retrieval
  • POST /api/config - configuration updates

JavaScript Integration Tests (TestFrontendJavaScriptIntegration)

  • Bearer token authentication pattern (makeAuthenticatedRequest)
  • 401 error handling
  • Queue operations compatibility

Error Handling Tests (TestFrontendErrorHandling)

  • JSON error responses
  • Validation error handling (400/422)

Real-Time Update Tests (TestFrontendRealTimeUpdates)

  • download_started notifications
  • download_completed notifications
  • Multiple clients receiving broadcasts

Data Format Tests (TestFrontendDataFormats)

  • Anime list format validation
  • Queue status format validation
  • WebSocket message format validation

Running the Tests

Run all frontend integration tests:

pytest tests/frontend/test_existing_ui_integration.py -v

Run specific test class:

pytest tests/frontend/test_existing_ui_integration.py::TestFrontendAuthentication -v

Run single test:

pytest tests/frontend/test_existing_ui_integration.py::TestFrontendAuthentication::test_login_returns_jwt_token -v

Key Test Patterns

Authenticated Client Fixture

Most tests use the authenticated_client fixture which:

  1. Sets up master password
  2. Logs in to get JWT token
  3. Adds Authorization header to all requests

WebSocket Testing

WebSocket tests use async context managers to establish connections:

async with authenticated_client.websocket_connect(
    f"/ws/connect?token={token}"
) as websocket:
    message = await websocket.receive_json()
    # Test message format

API Mocking

Service layer is mocked to isolate frontend-backend integration:

with patch("src.server.api.anime.get_anime_service") as mock:
    mock_service = AsyncMock()
    mock_service.get_all_series = AsyncMock(return_value=[...])
    mock.return_value = mock_service

Frontend JavaScript Files Tested

  • app.js: Main application logic, authentication, anime management
  • websocket_client.js: WebSocket client wrapper, connection management
  • queue.js: Download queue management, real-time updates

Integration Points Verified

  1. Authentication Flow: JWT token generation, validation, and usage
  2. API Endpoints: All REST API endpoints used by frontend
  3. WebSocket Communication: Real-time event broadcasting
  4. Data Formats: Response formats match frontend expectations
  5. Error Handling: Proper error responses for frontend consumption

Dependencies

  • pytest
  • pytest-asyncio
  • httpx (for async HTTP testing)
  • FastAPI test client with WebSocket support

Notes

  • Tests use in-memory state, no database persistence
  • Auth service is reset before each test
  • WebSocket service singleton is reused across tests
  • Fixtures are scoped appropriately to avoid test pollution