Add import-linter boundary to forbid routers importing app.dependencies
Issue #51: Enforce repository boundary at CI level using import-linter. Contract 'forbid_router_db_import' checks that app.routers never imports app.dependencies directly, keeping the DB access path through service contexts only. - Add import-linter>=2.0.0 to dev dependencies (backend/pyproject.toml) - Configure [tool.importlinter] with package_root and root_packages - Add [[tool.importlinter.contracts]] with type='forbidden', source app.routers, forbidden app.dependencies - Add 'Import Boundary' CI job (import-linter) - Document import-linter in CONTRIBUTING.md code quality table Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This commit is contained in:
21
.github/workflows/ci.yml
vendored
21
.github/workflows/ci.yml
vendored
@@ -78,3 +78,24 @@ jobs:
|
|||||||
|
|
||||||
- name: Run mypy
|
- name: Run mypy
|
||||||
run: mypy app
|
run: mypy app
|
||||||
|
|
||||||
|
import-linter:
|
||||||
|
name: Import Boundary
|
||||||
|
runs-on: ubuntu-latest
|
||||||
|
defaults:
|
||||||
|
run:
|
||||||
|
working-directory: backend
|
||||||
|
|
||||||
|
steps:
|
||||||
|
- uses: actions/checkout@v4
|
||||||
|
|
||||||
|
- name: Set up Python
|
||||||
|
uses: actions/setup-python@v5
|
||||||
|
with:
|
||||||
|
python-version: "3.12"
|
||||||
|
|
||||||
|
- name: Install dependencies
|
||||||
|
run: pip install -e ".[dev]"
|
||||||
|
|
||||||
|
- name: Run import-linter
|
||||||
|
run: linter
|
||||||
@@ -93,6 +93,7 @@ BanGUI/
|
|||||||
| `tsc --noEmit` | Frontend type checking | `cd frontend && tsc --noEmit` |
|
| `tsc --noEmit` | Frontend type checking | `cd frontend && tsc --noEmit` |
|
||||||
| `eslint` | Frontend linting | `cd frontend && eslint src` |
|
| `eslint` | Frontend linting | `cd frontend && eslint src` |
|
||||||
| `prettier --check` | Frontend formatting | `cd frontend && prettier --check src` |
|
| `prettier --check` | Frontend formatting | `cd frontend && prettier --check src` |
|
||||||
|
| `import-linter` | Layer boundary enforcement | `cd backend && linter` |
|
||||||
|
|
||||||
**All checks must pass before committing.** CI runs the same suite.
|
**All checks must pass before committing.** CI runs the same suite.
|
||||||
|
|
||||||
|
|||||||
@@ -31,6 +31,7 @@ dev = [
|
|||||||
"mypy>=1.13.0",
|
"mypy>=1.13.0",
|
||||||
"pytest-cov>=6.0.0",
|
"pytest-cov>=6.0.0",
|
||||||
"pytest-mock>=3.14.0",
|
"pytest-mock>=3.14.0",
|
||||||
|
"import-linter>=2.0.0",
|
||||||
]
|
]
|
||||||
|
|
||||||
[tool.hatch.build.targets.wheel]
|
[tool.hatch.build.targets.wheel]
|
||||||
@@ -64,3 +65,13 @@ pythonpath = [".", "../fail2ban-master"]
|
|||||||
testpaths = ["tests"]
|
testpaths = ["tests"]
|
||||||
addopts = "--asyncio-mode=auto --cov=app --cov-report=term-missing"
|
addopts = "--asyncio-mode=auto --cov=app --cov-report=term-missing"
|
||||||
filterwarnings = ["ignore::pytest.PytestRemovedIn9Warning"]
|
filterwarnings = ["ignore::pytest.PytestRemovedIn9Warning"]
|
||||||
|
|
||||||
|
[tool.importlinter]
|
||||||
|
package_root = "app"
|
||||||
|
root_packages = ["app"]
|
||||||
|
|
||||||
|
[[tool.importlinter.contracts]]
|
||||||
|
name = "forbid_router_db_import"
|
||||||
|
type = "forbidden"
|
||||||
|
source_modules = ["app.routers"]
|
||||||
|
forbidden_modules = ["app.dependencies"]
|
||||||
|
|||||||
Reference in New Issue
Block a user