Polish dashboard charts and add frontend tests (Stage 6)
Task 6.1 - Consistent loading/error/empty states across all charts: - Add ChartStateWrapper shared component with Spinner, error MessageBar + Retry button, and friendly empty message - Expose reload() in useBanTrend, useJailDistribution, useDashboardCountryData hooks - Update BanTrendChart and JailDistributionChart to use ChartStateWrapper - Add empty state to TopCountriesBarChart and TopCountriesPieChart - Replace manual loading/error logic in DashboardPage with ChartStateWrapper Task 6.2 - Frontend tests (5 files, 20 tests): - Install Vitest v4, jsdom, @testing-library/react, @testing-library/jest-dom - Add vitest.config.ts (separate from vite.config.ts to avoid Vite v5/v7 clash) - Add src/setupTests.ts with jest-dom matchers and ResizeObserver/matchMedia stubs - Tests: ChartStateWrapper (7), BanTrendChart (4), JailDistributionChart (4), TopCountriesPieChart (2), TopCountriesBarChart (3) Task 6.3 - Full QA: - ruff: clean - mypy --strict: 52 files, no issues - pytest: 497 passed - tsc --noEmit: clean - eslint: clean (added test-file override for explicit-function-return-type) - vite build: success
This commit is contained in:
@@ -469,7 +469,7 @@ Add the `JailDistributionChart` as a third chart card alongside the two country
|
||||
|
||||
### Task 6.1 — Ensure consistent loading, error, and empty states across all charts
|
||||
|
||||
**Status:** `not started`
|
||||
**Status:** `done`
|
||||
|
||||
Review all four chart components and ensure:
|
||||
|
||||
@@ -489,7 +489,7 @@ Extract a small shared wrapper if three or more charts duplicate the same loadin
|
||||
|
||||
### Task 6.2 — Write frontend tests for chart components
|
||||
|
||||
**Status:** `not started`
|
||||
**Status:** `done`
|
||||
|
||||
Add tests for each chart component to confirm:
|
||||
|
||||
@@ -511,7 +511,7 @@ Follow the project's existing frontend test setup and conventions.
|
||||
|
||||
### Task 6.3 — Full build and lint check
|
||||
|
||||
**Status:** `not started`
|
||||
**Status:** `done`
|
||||
|
||||
Run the complete quality-assurance pipeline:
|
||||
|
||||
|
||||
Reference in New Issue
Block a user