Remove Mock fallback from runtime_state and add runtime settings regression tests

backend/tests/test_utils/test_runtime_state.py

@@ -0,0 +1,47 @@
+from __future__ import annotations
+
+from unittest.mock import MagicMock
+
+from app.config import Settings
+from app.utils.runtime_state import get_app_settings, get_effective_settings
+
+
+class _FakeState:
+    def __init__(self, settings: Settings, runtime_settings: object | None = None) -> None:
+        self.settings = settings
+        self.runtime_settings = runtime_settings
+
+
+class _FakeApp:
+    def __init__(self, state: object) -> None:
+        self.state = state
+
+
+def test_get_effective_settings_returns_runtime_settings() -> None:
+    settings = Settings(session_secret="secret")
+    runtime_settings = settings.model_copy(update={"database_path": "/tmp/runtime.db"})
+    app = _FakeApp(_FakeState(settings=settings, runtime_settings=runtime_settings))
+
+    assert get_effective_settings(app) is runtime_settings
+
+
+def test_get_effective_settings_returns_app_settings_when_runtime_none() -> None:
+    settings = Settings(session_secret="secret")
+    app = _FakeApp(_FakeState(settings=settings))
+
+    assert get_effective_settings(app) is settings
+
+
+def test_get_effective_settings_returns_mock_runtime_settings() -> None:
+    settings = Settings(session_secret="secret")
+    mock_settings = MagicMock()
+    app = _FakeApp(_FakeState(settings=settings, runtime_settings=mock_settings))
+
+    assert get_effective_settings(app) is mock_settings
+
+
+def test_get_app_settings_reads_bootstrap_settings() -> None:
+    settings = Settings(session_secret="secret")
+    app = _FakeApp(_FakeState(settings=settings))
+
+    assert get_app_settings(app) is settings