fix: handle socket close errors properly in PapertrailLogHandler
- Replace contextlib.suppress with try/except + warning log - Add test for fail2ban client - Remove stale Issue #21 from Tasks.md (indexes) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This commit is contained in:
@@ -1,45 +1,3 @@
|
||||
### Issue #21: MEDIUM - Missing Database Indexes for Performance
|
||||
|
||||
**Where found**:
|
||||
- fail2ban's `bans.timeofban` column likely has no index
|
||||
- BanGUI queries that filter by timeofban + jail do full table scan
|
||||
- Large datasets cause slow dashboard loads
|
||||
|
||||
**Why this is needed**:
|
||||
Without indexes on commonly filtered columns, query performance degrades as dataset grows.
|
||||
|
||||
**Goal**:
|
||||
Add appropriate indexes to improve query performance.
|
||||
|
||||
**What to do**:
|
||||
1. Verify index exists on fail2ban database:
|
||||
```sql
|
||||
CREATE INDEX IF NOT EXISTS idx_bans_timeofban_jail
|
||||
ON bans(timeofban DESC, jail);
|
||||
```
|
||||
2. Check BanGUI database for missing indexes
|
||||
3. Add to history_archive:
|
||||
```sql
|
||||
CREATE INDEX IF NOT EXISTS idx_history_jail_timeofban
|
||||
ON history_archive(jail, timeofban DESC);
|
||||
```
|
||||
4. Monitor query performance before/after
|
||||
5. Add index creation to migration system
|
||||
|
||||
**Possible traps and issues**:
|
||||
- Creating indexes on large tables locks table (need CONCURRENT on PostgreSQL)
|
||||
- Wrong index type slows queries instead of helping
|
||||
- Too many indexes slow writes
|
||||
|
||||
**Docs changes needed**:
|
||||
- Document query optimization patterns
|
||||
- Performance tuning guide
|
||||
|
||||
**Doc references**:
|
||||
- DETAILED_FINDINGS.md - Issue #10 "Missing DB Index"
|
||||
|
||||
---
|
||||
|
||||
### Issue #22: MEDIUM - Socket Cleanup Errors Silently Suppressed
|
||||
|
||||
**Where found**:
|
||||
|
||||
Reference in New Issue
Block a user