Refactor periodic tasks to use injected scheduler resources

backend/tests/test_tasks/test_health_check.py

@@ -16,6 +16,7 @@ import pytest
 from app.models.config import PendingRecovery
 from app.models.server import ServerStatus
 from app.tasks.health_check import HEALTH_CHECK_INTERVAL, _run_probe, register
+from app.utils.runtime_state import ApplicationState, RuntimeState
 
 # ---------------------------------------------------------------------------
 # Helpers
@@ -31,12 +32,15 @@ def _make_app(prev_online: bool = False) -> MagicMock:
     Returns:
         A :class:`unittest.mock.MagicMock` that mimics ``fastapi.FastAPI``.
     """
+    runtime_state = RuntimeState(
+        server_status=ServerStatus(online=prev_online),
+        pending_recovery=None,
+        last_activation=None,
+    )
     app = MagicMock()
-    app.state.settings.fail2ban_socket = "/var/run/fail2ban/fail2ban.sock"
-    app.state.server_status = ServerStatus(online=prev_online)
+    app.state = ApplicationState(runtime_state)
+    app.state.settings = MagicMock(fail2ban_socket="/var/run/fail2ban/fail2ban.sock")
     app.state.scheduler = MagicMock()
-    app.state.last_activation = None
-    app.state.pending_recovery = None
     return app
 
 
@@ -232,14 +236,17 @@ class TestRegister:
         _, kwargs = app.state.scheduler.add_job.call_args
         assert kwargs["replace_existing"] is True
 
-    def test_register_passes_app_in_kwargs(self) -> None:
-        """The scheduled job must receive ``app`` as a kwarg for state access."""
+    def test_register_passes_resources_in_kwargs(self) -> None:
+        """The scheduled job must receive explicit resources instead of app."""
         app = _make_app()
 
         register(app)
 
         _, kwargs = app.state.scheduler.add_job.call_args
-        assert kwargs["kwargs"] == {"app": app}
+        assert kwargs["kwargs"] == {
+            "settings": app.state.settings,
+            "runtime_state": app.state.runtime_state,
+        }
 
     def test_register_initialises_last_activation_none(self) -> None:
         """``register`` must set ``app.state.last_activation = None``."""