feat: Task 4 — paginated banned-IPs section on jail detail page

Backend: - Add JailBannedIpsResponse Pydantic model (ban.py) - Add get_jail_banned_ips() service: server-side pagination, optional IP substring search, geo enrichment on page slice only (jail_service.py) - Add GET /api/jails/{name}/banned endpoint with page/page_size/search query params, 400/404/502 error handling (routers/jails.py) - 23 new tests: 13 service tests + 10 router tests (all passing) Frontend: - Add JailBannedIpsResponse TS interface (types/jail.ts) - Add jailBanned endpoint helper (api/endpoints.ts) - Add fetchJailBannedIps() API function (api/jails.ts) - Add BannedIpsSection component: Fluent UI DataGrid, debounced search (300 ms), prev/next pagination, page-size dropdown, per-row unban button, loading spinner, empty state, error MessageBar (BannedIpsSection.tsx) - Mount BannedIpsSection in JailDetailPage between stats and patterns - 12 new Vitest tests for BannedIpsSection (all passing)
2026-03-14 16:28:43 +01:00
parent 0966f347c4
commit baf45c6c62
12 changed files with 1333 additions and 3 deletions
--- a/backend/tests/test_routers/test_jails.py
+++ b/backend/tests/test_routers/test_jails.py
@@ -788,3 +788,146 @@ class TestFail2BanConnectionErrors:
            resp = await jails_client.post("/api/jails/sshd/reload")

        assert resp.status_code == 502
+
+
+# ---------------------------------------------------------------------------
+# GET /api/jails/{name}/banned
+# ---------------------------------------------------------------------------
+
+
+class TestGetJailBannedIps:
+    """Tests for ``GET /api/jails/{name}/banned``."""
+
+    def _mock_response(
+        self,
+        *,
+        items: list[dict] | None = None,
+        total: int = 2,
+        page: int = 1,
+        page_size: int = 25,
+    ) -> "JailBannedIpsResponse":  # type: ignore[name-defined]
+        from app.models.ban import ActiveBan, JailBannedIpsResponse
+
+        ban_items = (
+            [
+                ActiveBan(
+                    ip=item.get("ip", "1.2.3.4"),
+                    jail="sshd",
+                    banned_at=item.get("banned_at", "2025-01-01T10:00:00+00:00"),
+                    expires_at=item.get("expires_at", "2025-01-01T10:10:00+00:00"),
+                    ban_count=1,
+                    country=item.get("country", None),
+                )
+                for item in (items or [{"ip": "1.2.3.4"}, {"ip": "5.6.7.8"}])
+            ]
+        )
+        return JailBannedIpsResponse(
+            items=ban_items, total=total, page=page, page_size=page_size
+        )
+
+    async def test_200_returns_paginated_bans(self, jails_client: AsyncClient) -> None:
+        """GET /api/jails/sshd/banned returns 200 with a JailBannedIpsResponse."""
+        with patch(
+            "app.routers.jails.jail_service.get_jail_banned_ips",
+            AsyncMock(return_value=self._mock_response()),
+        ):
+            resp = await jails_client.get("/api/jails/sshd/banned")
+
+        assert resp.status_code == 200
+        data = resp.json()
+        assert "items" in data
+        assert "total" in data
+        assert "page" in data
+        assert "page_size" in data
+        assert data["total"] == 2
+
+    async def test_200_with_search_parameter(self, jails_client: AsyncClient) -> None:
+        """GET /api/jails/sshd/banned?search=1.2.3 passes search to service."""
+        mock_fn = AsyncMock(return_value=self._mock_response(items=[{"ip": "1.2.3.4"}], total=1))
+        with patch("app.routers.jails.jail_service.get_jail_banned_ips", mock_fn):
+            resp = await jails_client.get("/api/jails/sshd/banned?search=1.2.3")
+
+        assert resp.status_code == 200
+        _args, call_kwargs = mock_fn.call_args
+        assert call_kwargs.get("search") == "1.2.3"
+
+    async def test_200_with_page_and_page_size(self, jails_client: AsyncClient) -> None:
+        """GET /api/jails/sshd/banned?page=2&page_size=10 passes params to service."""
+        mock_fn = AsyncMock(
+            return_value=self._mock_response(page=2, page_size=10, total=0, items=[])
+        )
+        with patch("app.routers.jails.jail_service.get_jail_banned_ips", mock_fn):
+            resp = await jails_client.get("/api/jails/sshd/banned?page=2&page_size=10")
+
+        assert resp.status_code == 200
+        _args, call_kwargs = mock_fn.call_args
+        assert call_kwargs.get("page") == 2
+        assert call_kwargs.get("page_size") == 10
+
+    async def test_400_when_page_is_zero(self, jails_client: AsyncClient) -> None:
+        """GET /api/jails/sshd/banned?page=0 returns 400."""
+        resp = await jails_client.get("/api/jails/sshd/banned?page=0")
+        assert resp.status_code == 400
+
+    async def test_400_when_page_size_exceeds_max(self, jails_client: AsyncClient) -> None:
+        """GET /api/jails/sshd/banned?page_size=200 returns 400."""
+        resp = await jails_client.get("/api/jails/sshd/banned?page_size=200")
+        assert resp.status_code == 400
+
+    async def test_400_when_page_size_is_zero(self, jails_client: AsyncClient) -> None:
+        """GET /api/jails/sshd/banned?page_size=0 returns 400."""
+        resp = await jails_client.get("/api/jails/sshd/banned?page_size=0")
+        assert resp.status_code == 400
+
+    async def test_404_for_unknown_jail(self, jails_client: AsyncClient) -> None:
+        """GET /api/jails/ghost/banned returns 404 when jail is unknown."""
+        from app.services.jail_service import JailNotFoundError
+
+        with patch(
+            "app.routers.jails.jail_service.get_jail_banned_ips",
+            AsyncMock(side_effect=JailNotFoundError("ghost")),
+        ):
+            resp = await jails_client.get("/api/jails/ghost/banned")
+
+        assert resp.status_code == 404
+
+    async def test_502_when_fail2ban_unreachable(self, jails_client: AsyncClient) -> None:
+        """GET /api/jails/sshd/banned returns 502 when fail2ban is unreachable."""
+        from app.utils.fail2ban_client import Fail2BanConnectionError
+
+        with patch(
+            "app.routers.jails.jail_service.get_jail_banned_ips",
+            AsyncMock(
+                side_effect=Fail2BanConnectionError("socket dead", "/tmp/fake.sock")
+            ),
+        ):
+            resp = await jails_client.get("/api/jails/sshd/banned")
+
+        assert resp.status_code == 502
+
+    async def test_response_items_have_expected_fields(
+        self, jails_client: AsyncClient
+    ) -> None:
+        """Response items contain ip, jail, banned_at, expires_at, ban_count, country."""
+        with patch(
+            "app.routers.jails.jail_service.get_jail_banned_ips",
+            AsyncMock(return_value=self._mock_response()),
+        ):
+            resp = await jails_client.get("/api/jails/sshd/banned")
+
+        item = resp.json()["items"][0]
+        assert "ip" in item
+        assert "jail" in item
+        assert "banned_at" in item
+        assert "expires_at" in item
+        assert "ban_count" in item
+        assert "country" in item
+
+    async def test_401_when_unauthenticated(self, jails_client: AsyncClient) -> None:
+        """GET /api/jails/sshd/banned returns 401 without a session cookie."""
+        resp = await AsyncClient(
+            transport=ASGITransport(app=jails_client._transport.app),  # type: ignore[attr-defined]
+            base_url="http://test",
+        ).get("/api/jails/sshd/banned")
+        assert resp.status_code == 401
+