Refactor geo cache persistence into repository + remove raw SQL from tasks/main, update task list
This commit is contained in:
@@ -92,6 +92,8 @@ This document breaks the entire BanGUI project into development stages, ordered
|
||||
|
||||
#### TASK B-5 — Create a `geo_cache_repo` and remove direct SQL from `geo_service.py`
|
||||
|
||||
**Status:** Completed ✅
|
||||
|
||||
**Violated rule:** Refactoring.md §2.2 — Services must not execute raw SQL; go through a repository.
|
||||
|
||||
**Files affected:**
|
||||
@@ -113,6 +115,8 @@ This document breaks the entire BanGUI project into development stages, ordered
|
||||
|
||||
#### TASK B-6 — Remove direct SQL from `tasks/geo_re_resolve.py`
|
||||
|
||||
**Status:** Completed ✅
|
||||
|
||||
**Violated rule:** Refactoring.md §2.5 — Tasks must not use repositories directly; they must call a service method.
|
||||
|
||||
**Files affected:**
|
||||
@@ -163,6 +167,8 @@ Remove or rewrite the docstring snippet so it does not contain a bare `print()`
|
||||
|
||||
#### TASK B-9 — Remove direct SQL from `main.py` lifespan into `geo_service`
|
||||
|
||||
**Status:** Completed ✅
|
||||
|
||||
**Violated rule:** Refactoring.md §2 — Application startup code must not execute raw SQL; data-access logic belongs in a repository (or, when count semantics belong to a domain concern, a service method).
|
||||
|
||||
**Files affected:**
|
||||
|
||||
Reference in New Issue
Block a user