From def412797ae61e52008709734f0893b4adfeb431 Mon Sep 17 00:00:00 2001 From: Lukas Date: Sat, 25 Apr 2026 19:50:48 +0200 Subject: [PATCH] Remove completed task T-20 from documentation Removed the completed task about replacing inline style objects with makeStyles classes. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --- Docs/Tasks.md | 23 ----------------------- 1 file changed, 23 deletions(-) diff --git a/Docs/Tasks.md b/Docs/Tasks.md index 4e6db50..275049e 100644 --- a/Docs/Tasks.md +++ b/Docs/Tasks.md @@ -1,26 +1,3 @@ -### T-20 · Replace inline `style={{}}` objects with `makeStyles` classes - -**Where found:** `frontend/src/pages/map/MapBansTable.tsx` (multiple), `pages/JailDetailPage.tsx`, `pages/HistoryPage.tsx`, `pages/history/IpDetailView.tsx`, `components/WorldMap.tsx`, `components/TopCountriesPieChart.tsx`, `components/TopCountriesBarChart.tsx` - -**Why this is needed:** The project uses Fluent UI's `makeStyles` with atomic CSS caching. Inline `style={{}}` objects are allocated on every render, bypass the atomic CSS cache, and are inconsistent with the established pattern. Exceptions are acceptable only for truly dynamic values (e.g. tooltip `left`/`top` that change on mouse move) — static layout values must use `makeStyles`. - -**Goal:** All static layout properties moved to `makeStyles`. Inline styles only for genuinely dynamic values. - -**What to do:** -1. Audit each file listed above. -2. For static `display: flex`, `gap`, `margin`, `padding` — move to `makeStyles` in that component's style block. -3. Keep inline `style` only where the value is truly dynamic at runtime (e.g. `WorldMap` tooltip position, `TopCountriesBarChart` chart height). - -**Possible traps and issues:** -- `MapBansTable.tsx` has several consecutive inline `style` objects for its pagination row — these can be collapsed into one named class. -- Some components use both `tokens.*` values and inline styles — ensure `makeStyles` is imported where it isn't already. - -**Docs changes needed:** `Docs/Web-Development.md` — add styling rule: use `makeStyles` for all static styles; inline `style` only for runtime-dynamic values. - -**Doc references:** `Docs/Web-Development.md`, Fluent UI v9 docs on `makeStyles` - ---- - ### T-21 · `Fail2BanMetadataService` has inline socket timeout hardcoded **Where found:** `backend/app/services/fail2ban_metadata_service.py:64` — `socket_timeout: float = 5.0`