From fd685e82111a68293c8c6a8c06e2fc6c40c09260 Mon Sep 17 00:00:00 2001 From: Lukas Date: Thu, 23 Apr 2026 16:01:44 +0200 Subject: [PATCH] refactor: Remove unused HTTPException imports from routers After removing all try/except blocks that used HTTPException for domain exception conversion, these imports are no longer needed in the routers. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --- backend/app/routers/action_config.py | 9 +-------- backend/app/routers/bans.py | 4 +--- backend/app/routers/filter_config.py | 10 +--------- backend/app/routers/jail_config.py | 17 +---------------- backend/app/routers/server.py | 3 +-- 5 files changed, 5 insertions(+), 38 deletions(-) diff --git a/backend/app/routers/action_config.py b/backend/app/routers/action_config.py index 4124c85..2298316 100644 --- a/backend/app/routers/action_config.py +++ b/backend/app/routers/action_config.py @@ -2,16 +2,9 @@ from __future__ import annotations from typing import Annotated -from fastapi import APIRouter, HTTPException, Path, Query, Request, status +from fastapi import APIRouter, Path, Query, Request, status from app.dependencies import AuthDep, Fail2BanConfigDirDep, Fail2BanSocketDep -from app.exceptions import ( - ActionAlreadyExistsError, - ActionNameError, - ActionNotFoundError, - ActionReadonlyError, - ConfigWriteError, -) from app.models.config import ( ActionConfig, ActionCreateRequest, diff --git a/backend/app/routers/bans.py b/backend/app/routers/bans.py index 2e7cc17..1aa9777 100644 --- a/backend/app/routers/bans.py +++ b/backend/app/routers/bans.py @@ -10,7 +10,7 @@ Manual ban and unban operations and the active-bans overview: from __future__ import annotations -from fastapi import APIRouter, HTTPException, Request, status +from fastapi import APIRouter, Request, status from app.dependencies import ( AuthDep, @@ -19,11 +19,9 @@ from app.dependencies import ( GeoBatchLookupDep, HttpSessionDep, ) -from app.exceptions import JailNotFoundError, JailOperationError from app.models.ban import ActiveBanListResponse, BanRequest, UnbanAllResponse, UnbanRequest from app.models.jail import JailCommandResponse from app.services import ban_service, jail_service -from app.exceptions import Fail2BanConnectionError router: APIRouter = APIRouter(prefix="/api/bans", tags=["Bans"]) diff --git a/backend/app/routers/filter_config.py b/backend/app/routers/filter_config.py index b1f2eef..297cf75 100644 --- a/backend/app/routers/filter_config.py +++ b/backend/app/routers/filter_config.py @@ -2,17 +2,9 @@ from __future__ import annotations from typing import Annotated -from fastapi import APIRouter, HTTPException, Path, Query, Request, status +from fastapi import APIRouter, Path, Query, Request, status from app.dependencies import AuthDep, Fail2BanConfigDirDep, Fail2BanSocketDep -from app.exceptions import ( - ConfigWriteError, - FilterAlreadyExistsError, - FilterInvalidRegexError, - FilterNameError, - FilterNotFoundError, - FilterReadonlyError, -) from app.models.config import ( FilterConfig, FilterCreateRequest, diff --git a/backend/app/routers/jail_config.py b/backend/app/routers/jail_config.py index 466e064..b32b245 100644 --- a/backend/app/routers/jail_config.py +++ b/backend/app/routers/jail_config.py @@ -2,7 +2,7 @@ from __future__ import annotations from typing import Annotated -from fastapi import APIRouter, HTTPException, Path, Query, Request, status +from fastapi import APIRouter, Path, Query, Request, status from app.dependencies import ( AppDep, @@ -12,21 +12,6 @@ from app.dependencies import ( Fail2BanStartCommandDep, PendingRecoveryDep, ) -from app.exceptions import ( - ActionNameError, - ActionNotFoundError, - ConfigOperationError, - ConfigValidationError, - ConfigWriteError, - Fail2BanConnectionError, - FilterNameError, - FilterNotFoundError, - JailAlreadyActiveError, - JailAlreadyInactiveError, - JailNameError, - JailNotFoundError, - JailNotFoundInConfigError, -) from app.models.config import ( ActivateJailRequest, AddLogPathRequest, diff --git a/backend/app/routers/server.py b/backend/app/routers/server.py index e058b96..398897f 100644 --- a/backend/app/routers/server.py +++ b/backend/app/routers/server.py @@ -10,12 +10,11 @@ to flush log files. from __future__ import annotations -from fastapi import APIRouter, HTTPException, Request, status +from fastapi import APIRouter, Request, status from app.dependencies import AuthDep, Fail2BanSocketDep from app.models.server import ServerSettingsResponse, ServerSettingsUpdate from app.services import server_service -from app.exceptions import ServerOperationError, Fail2BanConnectionError router: APIRouter = APIRouter(prefix="/api/server", tags=["Server"])