Stale sessions from a stolen device could be reused up to the cache TTL after a legitimate user re-logs in, because login never cleared the existing cache entry. Changes: - Add invalidate_by_user(user_id) to SessionCache protocol - InMemorySessionCache maintains a user_id -> set[token] index to support O(1) invalidation of all sessions for a given user - NoOpSessionCache stub updated for API compatibility - auth_service.login() now returns the Session object alongside signed_token and expires_at - login router calls session_cache.invalidate_by_user(session.id) immediately after successful authentication Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
151 lines
5.5 KiB
Python
151 lines
5.5 KiB
Python
"""Pluggable session cache abstraction.
|
|
|
|
This module defines a cache interface for authenticated sessions and a default
|
|
process-local in-memory implementation. The backend can swap the cache
|
|
implementation without changing the authentication dependency logic.
|
|
|
|
⚠️ PROCESS-LOCAL CONSTRAINT (InMemorySessionCache)
|
|
====================================================
|
|
|
|
InMemorySessionCache stores validated sessions in a process-local dict.
|
|
This means:
|
|
- Each worker process has its own independent session cache.
|
|
- A session invalidated (logout) by worker A is still valid in worker B.
|
|
- Changes to the cache in one process are NOT visible to other processes.
|
|
|
|
IMPACT IN MULTI-WORKER DEPLOYMENTS:
|
|
- User logs out (worker A clears session from its cache).
|
|
- User makes a new request → routed to worker B.
|
|
- Worker B still has the stale session in its cache → request is accepted.
|
|
- User appears still logged in (from their perspective).
|
|
|
|
This is a CRITICAL SECURITY ISSUE: logout does not work reliably across workers.
|
|
|
|
SINGLE-WORKER ENFORCEMENT:
|
|
BanGUI enforces single-worker mode to prevent this issue:
|
|
1. Environment variable check: BANGUI_WORKERS must be 1 or unset
|
|
2. Database lock: Only one instance can run the scheduler at a time
|
|
3. Startup validation: Fails loudly if multi-worker scenario is detected
|
|
|
|
See Docs/Architekture.md § Deployment Constraints for full details.
|
|
|
|
MULTI-WORKER SOLUTION (Future):
|
|
If multi-worker support is needed in the future, replace InMemorySessionCache
|
|
with a shared backend such as:
|
|
- RedisSessionCache — backed by Redis (recommended for production)
|
|
- DatabaseSessionCache — backed by SQLite or PostgreSQL
|
|
- SharedMemorySessionCache — backed by IPC (for local multi-process)
|
|
|
|
The SessionCache Protocol is designed for pluggable backends:
|
|
class SessionCache(Protocol):
|
|
def get(token: str) -> Session | None: ...
|
|
def set(token: str, session: Session, ttl_seconds: float) -> None: ...
|
|
def invalidate(token: str) -> None: ...
|
|
def clear() -> None: ...
|
|
|
|
To add Redis support:
|
|
1. Create RedisSessionCache in this module (implements SessionCache)
|
|
2. Update app/main.py _update_session_cache() to instantiate RedisSessionCache
|
|
when BANGUI_REDIS_URL is configured
|
|
3. Update Backend-Development.md with multi-worker deployment guidelines
|
|
|
|
CURRENT STATUS:
|
|
For now, BanGUI is deployed as single-worker only. This constraint is
|
|
acceptable and keeps the implementation simple. The database-backed scheduler
|
|
lock ensures only one instance runs background jobs, even in container
|
|
orchestration scenarios where multiple instances may start.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
import time
|
|
from typing import TYPE_CHECKING, Protocol
|
|
|
|
if TYPE_CHECKING: # pragma: no cover
|
|
from app.models.auth import Session
|
|
|
|
|
|
class SessionCache(Protocol):
|
|
"""Interface for session token validation cache backends."""
|
|
|
|
def get(self, token: str) -> Session | None:
|
|
"""Return the cached session for *token*, or ``None`` if missing."""
|
|
|
|
def set(self, token: str, session: Session, ttl_seconds: float) -> None:
|
|
"""Cache the validated *session* for *token* for *ttl_seconds*."""
|
|
|
|
def invalidate(self, token: str) -> None:
|
|
"""Remove *token* from the cache if it exists."""
|
|
|
|
def invalidate_by_user(self, user_id: int) -> None:
|
|
"""Remove all cached sessions belonging to *user_id*."""
|
|
|
|
def clear(self) -> None:
|
|
"""Remove all entries from the cache."""
|
|
|
|
|
|
class InMemorySessionCache:
|
|
"""A process-local session cache implementation."""
|
|
|
|
def __init__(self) -> None:
|
|
self._entries: dict[str, tuple[Session, float]] = {}
|
|
self._user_index: dict[int, set[str]] = {}
|
|
|
|
def get(self, token: str) -> Session | None:
|
|
entry = self._entries.get(token)
|
|
if entry is None:
|
|
return None
|
|
|
|
session, expires_at = entry
|
|
if time.monotonic() >= expires_at:
|
|
self._entries.pop(token, None)
|
|
self._remove_from_user_index(token, session.id)
|
|
return None
|
|
return session
|
|
|
|
def set(self, token: str, session: Session, ttl_seconds: float) -> None:
|
|
expires_at = time.monotonic() + ttl_seconds
|
|
self._entries[token] = (session, expires_at)
|
|
self._user_index.setdefault(session.id, set()).add(token)
|
|
|
|
def invalidate(self, token: str) -> None:
|
|
entry = self._entries.pop(token, None)
|
|
if entry is not None:
|
|
self._remove_from_user_index(token, entry[0].id)
|
|
|
|
def invalidate_by_user(self, user_id: int) -> None:
|
|
"""Remove all cached sessions for *user_id*."""
|
|
tokens = self._user_index.pop(user_id, set())
|
|
for token in tokens:
|
|
self._entries.pop(token, None)
|
|
|
|
def clear(self) -> None:
|
|
self._entries.clear()
|
|
self._user_index.clear()
|
|
|
|
def _remove_from_user_index(self, token: str, user_id: int) -> None:
|
|
user_tokens = self._user_index.get(user_id)
|
|
if user_tokens is not None:
|
|
user_tokens.discard(token)
|
|
if not user_tokens:
|
|
self._user_index.pop(user_id, None)
|
|
|
|
|
|
class NoOpSessionCache:
|
|
"""A no-op session cache used when caching is disabled."""
|
|
|
|
def get(self, token: str) -> Session | None:
|
|
return None
|
|
|
|
def set(self, token: str, session: Session, ttl_seconds: float) -> None:
|
|
return None
|
|
|
|
def invalidate(self, token: str) -> None:
|
|
return None
|
|
|
|
def invalidate_by_user(self, user_id: int) -> None:
|
|
return None
|
|
|
|
def clear(self) -> None:
|
|
return None
|