fix(settings_modal): force click on modal overlay
Caveman commit: overlay click target area small, click miss. Add force=True. - Remove completed Task 4 from Docs/tasks.md - Fix flaky close modal via overlay test
This commit is contained in:
@@ -1,31 +1,3 @@
|
||||
## Task 4: Fix `Robot.Ui.Dashboard.Download Selected`
|
||||
|
||||
**Test File:** `tests/robot/ui/dashboard.robot`
|
||||
|
||||
**Error:**
|
||||
```
|
||||
'Mit Server verbunden' does not contain 'queue'
|
||||
```
|
||||
|
||||
**Context:**
|
||||
The test expects a toast notification containing "queue" after clicking download, but the toast message is in German ("Mit Server verbunden" = "Connected to server") and doesn't contain "queue".
|
||||
|
||||
**Root Cause:**
|
||||
The toast message returned by the backend is a German localized string that doesn't include the word "queue". The assertion is checking for English text.
|
||||
|
||||
**Fix Instructions:**
|
||||
Option A: Update the assertion to check for the actual German text or a different keyword:
|
||||
```robot
|
||||
# Check for German text or successful download indication
|
||||
Toast Should Contain verbund
|
||||
```
|
||||
|
||||
Option B: Update the backend to return a consistent toast message regardless of language.
|
||||
|
||||
Option C: If the download actually succeeds but the toast is different, update the test to verify the download started differently (e.g., check queue count changed).
|
||||
|
||||
---
|
||||
|
||||
## Task 5: Fix `Robot.Ui.Settings Modal.Close Settings Modal Via Overlay`
|
||||
|
||||
**Test File:** `tests/robot/ui/settings_modal.robot`
|
||||
|
||||
@@ -33,7 +33,7 @@ Close Settings Modal Via Overlay
|
||||
[Documentation] Click the modal overlay and verify the modal closes.
|
||||
Open Settings Modal
|
||||
Wait For Elements State css=#config-modal .modal-overlay visible timeout=5s
|
||||
Click css=#config-modal .modal-overlay
|
||||
Click css=#config-modal .modal-overlay force=True
|
||||
Wait For Elements State id=config-modal hidden timeout=3s
|
||||
Element Should Be Hidden id=config-modal
|
||||
|
||||
|
||||
Reference in New Issue
Block a user