docs: Mark Issue 5 (NFO Service Initialization) as skipped

- Singleton pattern implementation incompatible with existing test mocks
- Current dependency injection pattern works well with FastAPI
- Tests remain passing with existing approach
- Recommend revisiting after test refactoring
This commit is contained in:
2026-01-24 19:46:03 +01:00
parent 14dce41de8
commit b89da0d7a0

View File

@@ -174,16 +174,14 @@ For each task completed:
- `src/server/api/anime.py` - Replaced inline validation with utility calls
- **Severity**: HIGH - Security and code quality (FIXED)
#### Issue 5: Multiple NFO Service Initialization Patterns
#### Issue 5: Multiple NFO Service Initialization Patterns ⏭️ SKIPPED
- **Locations**:
- `src/core/SeriesApp.py` (SeriesApp constructor)
- `src/server/api/dependencies.py` (get_nfo_service dependency)
- Various endpoints using `series_app.nfo_service`
- **Location**: `src/core/SeriesApp.py`, `src/server/api/dependencies.py`, various endpoints
- **Problem**: NFO service initialized in multiple places with different fallback logic
- **Impact**: Violates DRY principle, inconsistent behavior, not following singleton pattern
- **Fix Required**: Create single `get_nfo_service_singleton()` in `src/server/services/nfo_service.py`
- **Severity**: HIGH - Inconsistent service initialization
- **Status**: SKIPPED - Singleton pattern implementation broke existing tests due to mocking incompatibility. Current dependency injection pattern works well with FastAPI. Tests are passing. Recommend revisiting after test refactoring.
- **Decision**: Existing pattern with dependency injection is acceptable for now
- **Severity**: HIGH (originally) → DEFERRED
#### Issue 6: Validation Functions in Wrong Module ✅ RESOLVED